User talk:DannyS712/DiscussionCloser

Suggestion

Thanks, nice script. I would like a couple of things though:

Option to remove {{nac}}: for some closes it's inappropriate for the venue and a pain to remove right after the edit.
A dropdown of useful characters (e.g. the endash (–) or four tildes). It's a pain having to go into a new tab, type 'endash', then copy and paste the symbol back.

Cheers, J 947 ^{^{^(c)}}, at 02:06, 30 March 2019 (UTC)[reply]

@J947: I agree with the thing about {{nac}}, and have been planning on solving that when I have time. As for the useful characters, I have no idea where to start with that, but I find that I don't need them. I just use "-" on the keyboard, and ~~~~ is also pretty easy to type. --DannyS712 (talk) 02:08, 30 March 2019 (UTC)[reply]

Fair enough, I agree that the second point is a minor one that doesn't need to be solved on reflection. Thanks for working on the {{nac}} thingamajig. J 947 ^{^{^(c)}}, at 02:13, 30 March 2019 (UTC)[reply]

@J947: I have completely removed the addition of the nac tag --DannyS712 (talk) 01:39, 13 June 2019 (UTC)[reply]

Could it be added back on an optional basis? Emir of Wikipedia (talk) 20:57, 25 August 2020 (UTC)[reply]

Suggestion for RM closure

@DannyS712: Instead of removing {{requested move/dated}} can the script rather replace it with {{subst:requested move/end}}? Per WP:RMCLOSE instructions. comrade waddie96 ★ (talk) 12:59, 6 November 2019 (UTC)[reply]

@Waddie96: I'll take a look DannyS712 (talk) 17:18, 6 November 2019 (UTC)[reply]

Suggestions

Overall it's a really neat and helpful script, but I do have a few suggestions:

Add support for {{Discussion top}} (({{dtop}}).
Increase the z-index to a high number like 1000 to prevent the sidebar going above the popup and background.
Use OOUI for the interface

– BrandonXLF (talk) 21:07, 17 December 2019 (UTC)[reply]

@DannyS712: It would also be nice if the window was movable and was more of a popup than an overlay, but the current system is fine.– BrandonXLF (talk) 06:09, 20 December 2019 (UTC)[reply]

@BrandonXLF: thanks for the ping; I'll take a look at writing a v.2 that uses OOUI DannyS712 (talk) 06:10, 20 December 2019 (UTC)[reply]

Script is broken

Whatever bottom script it substitutes is a redirect. The correct property to use is {{subst:RM bottom}}. CoronavirusPlagueDoctor (talk _{about the coronavirus}/Contributions _{about the coronavirus}) 22:34, 15 March 2020 (UTC)[reply]

@CoronavirusPlagueDoctor: Danny is fixing it. Interstellarity (talk) 22:47, 15 March 2020 (UTC)[reply]

Loads Twinkle

Hi @DannyS712, can you remove 'ext.gadget.Twinkle' in the dependencies list on line 298? I believe this was present because Abelmoshcus Esculentus' script originally depended on Morebits which wasn't a gadget by itself at that time. Now I don't see either Morebits or Twinkle being necessary for this to work. BTW even mediawiki.api and mediawiki.Title look unnecessary. – SD0001 (talk) 19:00, 8 April 2021 (UTC)[reply]

Reping @DannyS712. The presence of twinkle in dependencies is somewhat disruptive as it means that when a user disables Twinkle from their preferences, Twinkle still loads if the user has this script installed – but it won't be evident to them why Twinkle is still loading. For instance, this is a common point of confusion for new Twinkle developers (who need to disable on-wiki version of twinkle before they can test twinkle locally). – SD0001 (talk) 04:05, 18 November 2021 (UTC)[reply]

Done, sorry for not seeing this earlier DannyS712 (talk) 07:19, 20 November 2021 (UTC)[reply]

Script Bug

Your script is not working for me as shown here. Lightoil (talk) 20:35, 17 February 2023 (UTC)[reply]

@Lightoil. Try zooming out your browser a little bit. The buttons should then re-appear in the bottom left. –Novem Linguae (talk) 18:11, 23 June 2024 (UTC)[reply]

@Novem Linguae thanks but using a different computer has fixed the issue for me. Lightoil (talk) 20:30, 23 June 2024 (UTC)[reply]

Link not appearing

The link to close discussions isn't appearing for me at the top of sections. Valereee (talk) 12:53, 13 June 2024 (UTC)[reply]

Same here, unfortunately.

This may or may not be linked to the same MediaWiki updates as reported here: Wikipedia_talk:XFDcloser#XFDCloser_not_showing_up_in_Vector_2010. — kashmīrī ^TALK 16:49, 22 June 2024 (UTC)[reply]

Root cause is mw:Heading HTML changes. Is probably broken on old skins at the moment, and will break on Minerva and Vector 2022 in the coming weeks as they finish the rollout. –Novem Linguae (talk) 14:35, 23 June 2024 (UTC)[reply]

Dang, I use this script all the time. Valereee (talk) 15:12, 23 June 2024 (UTC)[reply]

What's the current status of this? Every day when I can't conveniently close something, I get sad all over again. Is there some fix that could be rolled out to match the new markup? RoySmith (talk) 13:41, 29 July 2024 (UTC)[reply]

@RoySmith I've a temporary fix at User:DaxServer/DiscussionCloser — DaxServer (t·m·e·c) 14:24, 29 July 2024 (UTC)[reply]

Ah, excellent. Take a barnstar out of petty cash :-) RoySmith (talk) 14:42, 29 July 2024 (UTC)[reply]

Patched version

Hi. I made a patched version here User:DaxServer/DiscussionCloser if someone is interested. This includes an added signature to the comment. The changes are minimal, I don't expect anything to break to the existing functionality. I'd recommend to disable this script before installing my patch as it might interfere.

cc @Valereee @Novem Linguae @Kashmiri — DaxServer (t·m·e·c) 10:57, 25 June 2024 (UTC)[reply]

@DaxServer. Thanks! Since you've now got this script top of mind, if you want to do more development on it, here's my personal list of bugs and feature requests: https://github.com/NovemLinguae/UserScripts/issues/122 –Novem Linguae (talk) 11:13, 25 June 2024 (UTC)[reply]

Thanks for tracking the issues. I think I'll do some dev on them! — DaxServer (t·m·e·c) 11:15, 25 June 2024 (UTC)[reply]

Thanks, DaxServer! Valereee (talk) 11:25, 25 June 2024 (UTC)[reply]

Big thanks, appears working for me! (The "Close" link is a bit misaligned vertically btw). — kashmīrī ^TALK 15:36, 25 June 2024 (UTC)[reply]

Yes, I am wondering if mediawiki software provided some usable styles which can be applied to custom components like the userscripts. I'm not exactly sure where I should be searching for those. Perhaps someone who knows then can point me in that direction, that'd be great! — DaxServer (t·m·e·c) 20:27, 25 June 2024 (UTC)[reply]

Thanks so much! voorts (talk/contributions) 22:23, 2 August 2024 (UTC)[reply]