User talk:Krinkle/Archive 2

Archive 1

Archive 2

Wikipedia:Village_pump_(technical)#Visual_editor_-_post_edit_notice

Can you comment on this? Can postedit be used, instead of jsMessage? πr² (t • c) 00:54, 3 July 2013 (UTC)

TemplateData editor

Hi,

Thanks for the bug reports. I wrote a message to Ltrlg about them. Are they really a problem ?

• I think the default value for "required" is false, so it's not important to have this line if "false" is the desired value. Do you think it should be added whatever its value ?
• Tabs or whitespace are equivalent for JSON I think.

I see <templatedata>...</templatedata> as a block of code that users shouldn't be preoccupied with its formatting, and it's not really important if the formatting changes when you modify this block with a tool. Technically, I don't see how a tool could keep the existing formatting of a JSON block, except by doing complex comparisons which won't bring any real value. --NicoV ^{(Talk on frwiki)} 05:44, 25 July 2013 (UTC)

Normalisation and conversion side-effects (whitespace and stripping of default values) is a problem in two ways:

• Different tools normalise in different ways (2 spaces, 4 spaces, 8 spaces, tabs, ..), thus cause every other edit to become a mess. Normalisation is only acceptable if it happens on the server-side and always in the same way.
• Stripping of default values is generally bad in my opinion as the defaults could change. Besides, this one is actually quite simple to prevent in a tool (parse the original object and keep it, don't build a new object from the form input but update the original based on values that were changed by the user, this will also prevent things like "[object Object]" unless the user touched that field).

There were other problems I noticed in your script, such as the "interesting" way in which it builds the JSON. There are built-in tools (both in the browser and in MediaWiki) to generate valid JSON. Concatenating strings seems like a rather complicated way to do it. Look into the native JSON.stringify( data, null, 4 );, for example (or the JSON2.js polyfill if you want to support older browsers).

I appreciate all the various efforts on such short notice coming from all of you to create different tools for it. However I'd prefer not to have them be promoted on the documentation page of the MediaWiki extension itself.

At this early stage, things will likely change a lot. The last thing I want to be occupied with right now is problems caused by side-effects introduced or broken by gadgets like these. Feel free to use them and promote them locally, but at least for now I'd like to not promote them on the extension page itself ("at your own risk", unofficial, kind of thing).

Lastly, I'd like to have an edit interface for this inside WikiEditor and/or VisualEditor and it should be maintained inside the extension, not separately as a gadget. That way when things change, it will be associated with the version installed on the wiki in question, and it would be a lot easier to maintain that way by having the two in 1 place. Of course, as usual, gadgets would remain able to override this feature with a different one to your liking, but at least there'd be an official one that is supported and maintained for all wikis/languages. Krinkle (talk) 15:41, 25 July 2013 (UTC)

Thanks for the answer. I totally agree that that kind of tools should be part of the extension itself (that's why I opened bugzilla 51734). Okay for the promotion on the extension page: I also added a list of tools on the TemplateData help page on mw, feel free to remove them if you think it's not appropriate (but it's the only common place between all the wikis).

I will transmit your remarks to Ltrlg. I only copied his script here, translated it into English and made some promotion on enwiki. But now the script on frwiki handles translation and being used from another wiki, so the only version is there. --NicoV ^{(Talk on frwiki)} 17:20, 25 July 2013 (UTC)

For JSON.stringify : I didn’t know the third argument (I thought only non-indented JSON can be generated), I will see how to use it.

Keeping the objet forces to rename a property at each time the user changes the name. Why not? This could simplify the script in some ways.

I can try to create an intelligent normaliser (at least detect tabulations; maybe number of space)

— Ltrl G^☎, 17:58, 25 July 2013 (UTC)

Wikipedia:Gadget/proposals#m:User:Erwin.2FSBHandler_-_Spam_blacklist_handler

Heads up! --Dirk Beetstra ^{T C} 09:55, 25 April 2014 (UTC)

ProveIt

Hey. I saw you made a cleanup edit to MediaWiki:Gadget-ProveIt.js. However, as I mentioned at the top of the file, I track this in git (pull requests always welcome). Currently, there is a pretty significant bug open, which is fixed and tested locally. I'm going to release the version from git (to fix the bug), and then remerge your changes into the git repository. I've made a GitHub issue so I won't forget. Thanks again. Superm401 - Talk 22:26, 29 June 2014 (UTC)

Sorry, it actually linked to Google Code, but that points to GitHub since I moved there. Superm401 - Talk 22:29, 29 June 2014 (UTC)

I've now merged your change into git and deployed it (along with a couple other things). Thanks again, and sorry for the delay. Superm401 - Talk 04:09, 27 July 2014 (UTC)

Optional modules

Hey, I saw this change you made and wanted to ask: where can I learn more about which modules are optional? I've been assuming that I could rely on the contents of the mw object, so I'd like to learn more to avoid the mistake. Thanks, {{Nihiltres|talk|edits}} 15:42, 9 July 2014 (UTC)

@Nihiltres: All modules are optional. The only thing available synchronously by default are the deprecated legacy functions from the "wikibits" module. All other modules should be explicitly declared as dependency to ensure that they will be loaded and (more importantly) that your code executes after it has finished loading. Modules like "mediawiki.util" are almost always available because it's most likely there will be another gadget on the page that loaded it for you already, but that's a fragile thing to depend on. And, while it does load the module, it may not load it in time.
See also ResourceLoader/Modules, ResourceLoader/Migration guide, mw:Developing with ResourceLoader
Krinkle (talk) 15:54, 9 July 2014 (UTC)

Safer...

...in which sense? Helder.wiki 17:25, 9 July 2014 (UTC)

@Helder.wiki: I added that code minutes earlier in the previous edit. It's safer by not relying on $.param to cast non-string values to strings (and cast them as "false"/"true"; not 0/1). In this case AutoEd doesn't inspect the value at all, but I'd rather have the value used be explicitly there, since there is no such thing as boolean values in a query string. Krinkle (talk) 18:58, 9 July 2014 (UTC)

Ok. Helder.wiki 19:12, 9 July 2014 (UTC) PS: be aware that edits like this do not generate notifications due to bugzilla:54639.

cursor hover translation for all of wikipedia

Hi Krinkle,

I noticed you put some documentation on top of my GoogleTrans gadget.

I also noticed you are an actual developer of wikimedia.

How about a cursor hover translation feature for all of Wikipedia. The GoogleTrans gadget certainly shows it can be done.

Having all knowledge in one place for all people is a truly noble goal, but isn't overcoming language barriers an associated and also noble goal for such a project. And cursor hover translation certainly is quicker to look up a word (or small amounts of selected text -- which GoogleTrans also does) than manually looking up a dictionary.

Google isn't maintaining the word translator in the Google toolbar anymore. There is imtranslator.net, but it is a bit clunky with an extra translation window hanging around the screen. Cursor hover translation is also very good when you are trying to brush up on a language, when you know it a bit and want to get better at it, like Russian speakers in the Ukraine trying to learn a bit of Ukrainian, or English speaking Canadians trying to brush up on their high school French. The full page translations that Google does are not very good if you are actually trying to learn the source language. For instance, I can read French well, but will need to translate a word every paragraph or so. And, as for my Spanish, I need this once or twice a sentence.

Reading other wiki languages is very good for your understanding of the world. I remember reading in the eswiki that the USA had to borrow 41 cents to every dollar it spent recently. That was a very good statement that the US really was in budget problems. Such a detail would have been scrubbed out of the enwiki by legislative aids in Washington. So, as it turns out, in a world where everybody uses the enwiki, it's difficult to put embarrassing truth in an article there. This means you need to be able to read a wiki other than the enwiki to get a good view of a contraversial subject. This means you will be rewarded by reading wikis in languages you are not fully proficient in. This means that cursor hover word and selected text translation is an aid that will help this.

As for cost, I don't think it will be that much. Google charges 20$ a million characters of translation, that's 5000 translations for a dollar if each word is 10 characters. Perhaps only allowing single word translations instead of selected text might keep the cost manageable.

Endo999 (talk) 02:06, 28 August 2014 (UTC)

Oh Krinkle,

I like the hovercards, good feature.

Endo999 (talk) 02:09, 28 August 2014 (UTC)

Hi Endo999,

I maintain user scripts, gadgets and contribute to the wiki, in my spare time as a volunteer. I also work as a Wikimedia developer on the MediaWiki software, the infrastructure behind it, and various products used alongside it such as VisualEditor (see mw:User:Krinkle). I'm not directly involved with Hovercards but I'm glad you like it!

Having inline translations sounds like an interesting idea to incorporate into a native MediaWiki extension. I'm not in a position to decide whether we can use Google's services, but I'd recommend getting in touch with the Wikimedia Language engineering team to find out. Perhaps e-mail Alolita Sharma and see what the possibilities are. --Krinkle (talk) 23:12, 29 August 2014 (UTC)

Template:Editnotice load

Is there any way you could make this work without adding tons of pages to Category:Pages using duplicate arguments in template calls? Plastikspork _―Œ^(talk) 04:25, 31 March 2015 (UTC)

Thanks. Replied at Wikipedia talk:Editnotice#Make use of MediaWiki:Editnotice-notext. --Krinkle (talk) 05:16, 31 March 2015 (UTC)

RTRC is not working

RTRC worked till yesterday but now it just loads forever. It never happened before. Can you fix the problem? Supdiop ^talk 07:28, 18 June 2015 (UTC)

It started working again, maybe I should have waited for some time. Supdiop ^talk 17:51, 18 June 2015 (UTC)

@Supdiop: No, please don't wait! I was able to fix it this quickly largely thanks to your message. There isn't a whole lot I can do since Wikimedia Labs having issues is what caused the problem (see labs-announce post). However I was able to improve RTRC's initialisation process to failover more gracefully. From now on, the application will continue to load if Labs is unavailable – though without the latest interface and translation data (which come from translatewiki.net, via my Tool Labs tool). Thanks! --Krinkle (talk) 18:27, 18 June 2015 (UTC)

Thanks for fixing it very quickly and also for creating it! I will notify you if it happens again. Supdiop ^talk 20:28, 18 June 2015 (UTC)

Navigation popups

Please see Wikipedia talk:Tools/Navigation popups#Anyone else getting recent breakage?. Will popups be restored please? DuncanHill (talk) 01:44, 7 August 2015 (UTC)

Thanks for notifying me. It looks like the issue has been resolved. I'm glad popups can finally enjoy in the performance optimisations provided by ResourceLoader. Krinkle (talk) 17:26, 7 August 2015 (UTC)

Help to install Real-Time recent Changes tool

Hi, I am partoller at wiki commons. I would like to use Real-Time recent Changes tool to patrol recent changes in commons. please help me to use it. I tried a lot, but i failed. i need your kind help. I am waiting your instructions. -- --Iqsrb722 (talk) 05:07, 15 November 2015 (UTC)

@Iqsrb722: I works for me at commons:Special:BlankPage/RTRC. In what way is it failing? –Krinkle 00:40, 17 November 2015 (UTC)

No, actually i could not find the link, thats why i disturbed you, Oh, thanks for your kind assistance.--Iqsrb722 (talk) 07:47, 17 November 2015 (UTC)

@Iqsrb722: Cool, I'm glad it's working. Thanks for using RTRC! –Krinkle 16:05, 17 November 2015 (UTC)

Rollback scripts

Hey, Krinkle, Elitre pinged you on my talk page, but I wanted to double up here, just in case (I'm sure you're not getting enough messages about this already! :D ). Anyway, I know from VPT that the changes to the rollback function were to be reverted, which might be why my script (User:Writ Keeper/Scripts/massRollback.js) started working again, after people had reported problems with it earlier today. I also made a fix to it; originally, I was scavenging the rollback token from the URLs of the rollback links, to save on the API call, but since I guess they're shifting to POST instead of GET, the rollback token will be taken out of the URL. So I stopped being lazy and just implemented the API call to get the token.

So, ultimately, is that all I need to do to keep this working in the future? What else might I need to do? I guess I'm not sure exactly how the rollback function is/will be changing, and how it would affect the API calls I'm making in my script. Any help would be appreciated, thanks! Writ Keeper ⚇♔ 18:56, 27 May 2016 (UTC)

@Writ Keeper: Yep, that's all. But, I do have a few further suggestions for you: edit 1, edit 2, and (biggest) edit 3. --Greetings, Krinkle (talk) 19:35, 27 May 2016 (UTC)

I've made the first two suggested changes (thanks!). Y'know, as far as the third goes, people keep trying to get me to use the mw.api instead of straight jQuery calls; why is that? I mean, in this case, I guess it saves us from having a separate call for the rollback token, which is definitely nice. But by and large, I don't really feel like it's that much simpler than just using jQuery, though admittedly that's likely because I'm just used to jQuery. What's the case to be made for switching to the mw.api calls? Writ Keeper ⚇♔ 20:34, 27 May 2016 (UTC)

KrinkleBot not working

Hi Krinkle, I changed some pictures for the Main Page at Wikipedia:Main Page/Commons media protection, but KrinkleBot has not yet protected them at Commons, c:Commons:Auto-protected files/wikipedia/en. Can you see what's wrong? Stephen 04:03, 29 August 2016 (UTC)

@Step: Thanks, it's back up now. –Krinkle (talk) 20:54, 4 September 2016 (UTC)

Krinkle: The bot doesn't appear to be functioning. —David Levy 22:19, 13 October 2016 (UTC)

Replied on Commons. (Fixed last week.) –Krinkle (talk) 21:45, 19 October 2016 (UTC)

Krinkle: The bot appears to be down again. —David Levy 02:26, 19 November 2016 (UTC)

Wow, that was fast. Thanks! —David Levy 02:35, 19 November 2016 (UTC)

A barnstar for you!

	The Technical Barnstar
	Thanks again for resolving the issues I've had with my installed JavaScripts. MCMLXXXIX 05:23, 21 March 2017 (UTC)

JavaScript programmers needed at WT:WPPORT

The portal system is being overhauled.

They could really use some input from JS programmers on what is possible.    — The Transhumanist   22:44, 14 May 2018 (UTC)

Heightline

Please see WP:RS. The content should be removed as this website is at best, spam. It can never, under any circumstance be used to source anything on Wikipedia. You can see many discussions about this and related websites at WP:RSN. Praxidicae (talk) 10:10, 4 October 2018 (UTC)

New Year's Day

Thanks for your fix at New Year's day. Unfortunately, the link was broken by an over-enthusiastic editor who mistook my insertion of the date template with changes to the dates! I had to undo your edit to reinstate the date markup, but I've ensured your correction is still there. Thanks. The Parson's Cat (talk) 09:15, 2 January 2019 (UTC)

A page you started (ESLint) has been reviewed!

Thanks for creating ESLint.

User:Atsme while reveiwing this page as a part of our page curation process had the following comments:

The article needs RS (not blogs, PRs) and has been tagged as such.

To reply, leave a comment here and prepend it with {{Re|Atsme}}. And, don't forget to sign your reply with ~~~~ .

Message delivered via the Page Curation tool, on behalf of the reviewer.

^Atsme _Talk 📧 13:36, 7 July 2019 (UTC)

@Atsme: Is there a specific statement or claim that you believe should have a better source, or do you mean a better source to indicate the notability of the subject? --Krinkle (talk) 14:10, 7 July 2019 (UTC)

Hi, Krinkle - there are quite a few refs that are blogs, one is a PR. My suggestion is more along the line of adding updated academic and/or MSM sources for the benefit of our readers. Of course, if the blogs are authored by independent experts, that's fine. There's no question that the article passes notability but by now, there should be some higher quality secondary sources out there. I was also wondering if ESLint was one of the tools our techs use to clean up lint on the pedia. Happy editing!! ^Atsme _Talk 📧 15:10, 7 July 2019 (UTC)