User talk:Aaron Liu/Watchlyst Greybar Unsin

Broken indeed

Hi there Aaron Liu, this script does not appear to be compatible with the WP:SHORTDESCHELPER, is it known? Vanderwaalforces (talk) 14:28, 11 January 2024 (UTC)[reply]

Thanks for using!
Hmm, I don’t know about that. This script is currently supposed to be stable, lol. I’ll try debugging it. If anything it shouldn’t be a problem as we use the MW API to add the subtitle. Aaron Liu (talk) 14:44, 11 January 2024 (UTC)[reply]

@Vanderwaalforces It works for me, what happens for you? Or do you need some better dipoles? Aaron Liu (talk) 15:15, 11 January 2024 (UTC)[reply]

@Aaron Liu I could no longer edit short descriptions after installing this script. I try clicking the buttons it just doesn't respond to me. But, it worked immediately after uninstalling this script. Strang though. Vanderwaalforces (talk) 15:37, 11 January 2024 (UTC)[reply]

It works perfectly for me in both V22 and Monobook. Aaron Liu (talk) 15:49, 11 January 2024 (UTC)[reply]

You know what? I’ll try it again now :) Vanderwaalforces (talk) 17:17, 11 January 2024 (UTC)[reply]

Categorization items not shown

Hello Aaron Liu. I don't know why, but watchlist items related to [de]categorization are always marked as read; so they never show up on the Greybar as your API call is limited to unread items. I guess you have to tweak the script to show them, like by getting all (read and unread) changes and filter them by unread edits plus categorization items. What do you think?

BTW I was localizing your script for fawiki when I noticed this bug. This is awesome and I want to thank you for writing it. Jeeputer ^Talk 08:58, 4 April 2024 (UTC)[reply]

Another thing I discovered is that ( data.type === 'new' ? 'created' : 'changed' ) on L-28 will never return "created", because you are already in a case block of data.type === 'edit'

Maybe you can fix the problem of new page creation items not showing up by introducing another case: 'new' to that switch statement. Jeeputer ^Talk 09:47, 4 April 2024 (UTC)[reply]

I've fixed the case block ('changed' is probably a no-op now) and filed T36185. Thanks for using my script!
BTW, that part was a relic of the early days where we only supported edit-like messages. Aaron Liu (talk) 16:55, 4 April 2024 (UTC)[reply]

Well thanks. I know what happened to that phab link :D, just for others seeing this thread: the correct link to the phabricator task is T361855.

Thank you, I will follow the task.

I am using Ais523's watchlist notifier on fawiki, but I will update that script to localized version of yours if you don't mind. These new features are useful for me just like the script itself. Jeeputer ^Talk 17:43, 4 April 2024 (UTC)[reply]

embarrassment
Go ahead! Just remember to keep access to the source code public Aaron Liu (talk) 17:49, 4 April 2024 (UTC)[reply]

Good eye! I'll check this out. Aaron Liu (talk) 11:53, 4 April 2024 (UTC)[reply]