Template talk:Category series navigation/Archive 3

This is an archive of past discussions about Template:Category series navigation. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page.

Archive 1

Archive 2

Archive 3

max-width

@Tom.Reding, hi, what is the point of max-width: calc(100% - 25em); that you added?

You get a weird look on small screens. Jack who built the house (talk) 15:38, 14 December 2023 (UTC)

@JWBTH: thanks for the image. I originally added max-width to the sandbox here, probably from Module:Navseasoncats with year navigation. Since that module was deleted, I can't check the history for who put that in, but I don't think it was me, and I have a hunch that it was BrownHairedGirl, who is unfortunately also unreachable for now. But I also have a hunch that it has/had to do with navs that have a stack of portals on the right side of the page such as {{Year in nationality television category}}'s use on Category:1957 in American television:

I removed max-width in the sandbox, which produces:

which I think is an improvement. The portals do eventually invade onto the upper nav, but only at very narrow widths, and there is much less forced whitespace at all widths, and the navs are closer to the center of page to boot.

Category:2014's live & sandbox navs for comparison:

What do you think? ~ Tom.Reding (talk ⋅dgaf) 16:57, 14 December 2023 (UTC)

@Tom.Reding: I think it looks good, and even the portals invade onto the nav, that's expected behavior. Browsers correctly center elements with margin: auto; when there is a floating element on the right/left (e.g. here the navigation is centered between the left edge of the page and the portals, not the right edge of the page) – there is no need to tweak anything to make it render correctly. Thanks for the quick reaction. Jack who built the house (talk) 17:41, 14 December 2023 (UTC)

Live ~ Tom.Reding (talk ⋅dgaf) 18:04, 14 December 2023 (UTC)

@JWBTH: on certain categories where the amount of text and the number of portals is just right (e.g. 2000s Ecuadorian television series), the upper and lower navs are not horizontally aligned for a range of medium-sized widths (they are properly aligned for both very wide and very narrow widths):

Television series which originated in Ecuador in the decade 2000s. i.e. in the years 2000 to 2009. Television shows that originated in other countries and only later aired in Ecuador should be removed from this category and its sub-categories

1950s
1960s
1970s
1980s
1990s
2000s
2010s
2020s
2030s
2040s
2050s

16th
17th
18th
19th
20th
21st
22nd
23rd
24th
25th
26th

The simplest solution is to add a {{Clear}} before {{Category series navigation}} in the category template, in this case {{Decade nationality television series category/core/sandbox}}:

Television series which originated in Ecuador in the decade 2000s. i.e. in the years 2000 to 2009. Television shows that originated in other countries and only later aired in Ecuador should be removed from this category and its sub-categories

1950s
1960s
1970s
1980s
1990s
2000s
2010s
2020s
2030s
2040s
2050s

16th
17th
18th
19th
20th
21st
22nd
23rd
24th
25th
26th

~ Tom.Reding (talk ⋅dgaf) 16:45, 26 December 2023 (UTC)

@Tom.Reding: You're right: {{clear}} is a simple solution. But a dirty one. I believe the solution should be to wrap the whole block in an element with appropriate CSS so that they are aligned together. It can also be a good idea to get rid of a table here and use a <div>...</div> with ARIA attributes like role="navigation" to make the element accessible. Jack who built the house (talk) 17:20, 26 December 2023 (UTC)

@JWBTH: That definitely sounds better. Could you demonstrate that on the necessary {{Decade nationality television series category}} sandboxes? ~ Tom.Reding (talk ⋅dgaf) 17:32, 26 December 2023 (UTC)

I'll try. Jack who built the house (talk) 17:42, 26 December 2023 (UTC)

@Tom.Reding: here you go:

Television series which originated in Ecuador in the decade 2000s. i.e. in the years 2000 to 2009. Television shows that originated in other countries and only later aired in Ecuador should be removed from this category and its sub-categories

I changed Module:Category series navigation/sandbox and added Module:Category series navigation/styles.css. Jack who built the house (talk) 23:18, 26 December 2023 (UTC)

@JWBTH: thank you for that. I'm not familiar with css at all. That was a lot more complex and broader in scope than I was expecting!

I created Template:Category series navigation/testcases17 for 1, 2, and 3 portals, and looked through all the other testcases, and they all look good. However, syntax highlighting and the shortened heading in the section below suggest there's a missing </div> somewhere.

After looking at Template:Hlist/styles.css, I'm wondering if the settings in Module:Category series navigation/styles.css need to be checked/tweaked for all skins, or is that something you already did too? ~ Tom.Reding (talk ⋅dgaf) 06:38, 27 December 2023 (UTC)

thank you for that. I'm not familiar with css at all. That was a lot more complex and broader in scope than I was expecting!
You're welcome.

However, syntax highlighting and the shortened heading in the section below suggest there's a missing </div> somewhere.
Ah, that's just me incorrectly copying the result of {{#tag:pre|{{Decade nationality television series category/sandbox}}}}. Fixed.

I'm wondering if the settings in Module:Category series navigation/styles.css need to be checked/tweaked for all skins, or is that something you already did too?
Conversely, I tried to level out the differences between skins (they have them in the toccolours class). But Vector 2022 and Minerva don't have this class (and the top and bottom nav look the same in them), and I didn't touch it. Jack who built the house (talk) 07:20, 27 December 2023 (UTC)

@JWBTH: it seems I got busy/distracted and did not implement your sandbox changes into the live module. Is everything in the sandbox as you like it? I need to add some BC-functionality, so will piggyback that onto your presumably ready changes. ~ Tom.Reding (talk ⋅dgaf) 13:35, 28 January 2024 (UTC)

@Tom.Reding: Yeah, everything was good at the moment of our dialog. Jack who built the house (talk) 11:56, 29 January 2024 (UTC)

Television season pages

The new naming convention for television season pages seems to have broken navigation with this template. See Category:30 Rock season 1 episodes, which does not link to Category:30 Rock season 2 episodes. Gonnym (talk) 13:04, 2 April 2024 (UTC)

I don't have time to dig into the module (which I've never worked with before) but it looks like the () code at Module:Category_series_navigation#L-1921 will need to be tweaked, then just modify Module:Category_series_navigation#L-957 to match. Primefac (talk) 13:12, 2 April 2024 (UTC)

@Gonnym and Primefac:

Updated! ~ Tom.Reding (talk ⋅dgaf) 15:31, 2 April 2024 (UTC)