Module talk:College color/Archive 7

Archive 1

←

Archive 5

Archive 6

Archive 7

Template-protected edit request on 21 October 2024

Request to add the Fullerton Hornets in the list of college colors.

["Fullerton Hornets"] = {"0F406B", "FFFFFF", "FFD600", name1="Stinger blue", name3="hornet yellow", cite=""Colors". Retrieved October 21, 2024."},

Thetreesarespeakingtome (talk) 21:30, 21 October 2024 (UTC)

 Done ~ Dissident93 ^(talk) 13:43, 22 October 2024 (UTC)

Template-protected edit request on 18 October 2024

Changes made to this module over the previous 16 hours are causing widespread display issues when Template:NCAA color cell, Template:CollegeSecondaryHeader and Template:CollegeSecondaryStyle are used. Text is no longer visible. For examples, please see 2023–24 Indiana Hoosiers men's basketball team, 2023–24 North Carolina Tar Heels men's basketball team and 2023–24 Le Moyne Dolphins men's basketball team. Please roll back the changes that have been made. It seems that it would have been preferable to test these changes in a sandbox first. Taxman1913 (talk) 15:35, 18 October 2024 (UTC)

@Dissident93: The changes you have made over the past two days have broken the display of multiple templates. Please undo your changes and remember to test changes you want to make in the module sandbox before making the changes to the live module.

Also pinging Frietjes as the most recent template editor before the recent disruptive edits. — Jkudlick ⚓ (talk) 21:16, 19 October 2024 (UTC)

I wasn't aware the edits, which were done to apply a fix for night mode, weren't working in other spaces as I was just using college football players to test them. The last good version is now live until all issues are addressed. ~ Dissident93 ^(talk) 21:53, 19 October 2024 (UTC)

@Taxman1913: all three of the pages look fine to me now after applying a fix, do they on your end? ~ Dissident93 ^(talk) 03:15, 20 October 2024 (UTC)

@Dissident93 and Taxman1913: The new fix looks good at 2024 Navy Midshipmen football season and several other random sports pages I viewed. I think we are good to call this edit request |answered=yes. — Jkudlick ⚓ (talk) 17:28, 21 October 2024 (UTC)

@Dissident93 and Jkudlick: It is still not working as before. At 2023–24 Le Moyne Dolphins men's basketball team#Player_statistics, the text in the table is rendering as black instead of gold. At 2023–24 Indiana Hoosiers men's basketball team#Player_statistics, the text should be white, but it is rendering as black, which provides little contrast. Taxman1913 (talk) 17:49, 21 October 2024 (UTC)

I'm really not sure what's going on here. Obviously my Lua knowledge is lacking, but all it should be doing is preventing colors from being affected when switching to night mode. I haven't had any of these other issues when doing the same to other color modules. @Frietjes: could you take a look at this? ~ Dissident93 ^(talk) 19:22, 21 October 2024 (UTC)

I think part of the problem is the additional whitespace in the style declaration. for example

!colspan=12 style={{NCAA color cell|Le Moyne Dolphins}}

expands to

!colspan=12 style=background-color:#00452A !important;color:#FFFFFF !important;

which has no quotes around the style statement. it was probably working before because there was no whitespace there. so, if you want to make that work, you will need to make sure that all uses have quotes around the call. in other words, you need to change these to

!colspan=12 style="{{NCAA color cell|Le Moyne Dolphins}}"

to make it work. Frietjes (talk) 20:45, 21 October 2024 (UTC)

@Frietjes: I just tested adding quotes to the style statement. The text now renders as white (previously black) instead of gold. The wikilinked words in the top row were made gold along the spans to match the color used in the other cells. Template:NCAA color cell is no longer finding the secondary color. I'm not sure why the quotes change the text from black to white, but they did not become gold. Taxman1913 (talk) 20:59, 21 October 2024 (UTC)

@Frietjes: I just added quotes to the style statement for the top row of both tables at 2023–24 Le Moyne Dolphins men's basketball team#Awards_and_honors. Before adding the quotes, the text was being rendered as black. It was ignoring the color parameter being given. Now, the text renders as white, as it did before changes were made to the module. It would appear the template is now recognizing the text color as white as requested in the parameter. However, when I changed 2023–24 Le Moyne Dolphins men's basketball team#Player_statistics to

!colspan="2" style="{{NCAA color cell|Le Moyne Dolphins|color=#FCE300}}" |Minutes

I also got white text, not gold as the parameter specified. So, no matter which color is entered in the parameter, adding quotes to the style statement now produces white text. I also tried it with "purple" instead of #FCE300. I still got white text. I also get white text with FCE300 (without the hashtag). Taxman1913 (talk) 21:20, 21 October 2024 (UTC)

Taxman1913, looking at the documentation for {{NCAA color cell}}, I don't see an option for overriding the font color. I do see this for {{CollegePrimaryStyle}} and {{CollegeSecondaryStyle}}, but not for {{NCAA color cell}}? Frietjes (talk) 22:15, 21 October 2024 (UTC)

@Frietjes: I didn't check that before I tried it. I was just throwing spaghetti at the wall to see whether it would stick, based on the experience I had with the other template. I was hoping to identify a pattern that might be helpful. Taxman1913 (talk) 04:15, 22 October 2024 (UTC)

in any case, I did an insource search and found 5500 articles without the quotes, so potentially a lot of pages are broken right now. Frietjes (talk) 23:05, 21 October 2024 (UTC)

Should we just revert to the version before I attempted dark mode fixes? If I had known it would be this disruptive I probably wouldn't have bothered. ~ Dissident93 ^(talk) 23:16, 21 October 2024 (UTC)

I've gone ahead and did that until the issues can be addressed. I've had none of these issues on other color modules; this one is just made more complex by having font colors using auto contrast that clearly I did not fix correctly and might have to be implemented in another way. ~ Dissident93 ^(talk) 13:37, 22 October 2024 (UTC)

Dissident93, you could make a WP:BOTREQ to add quotes and once that is complete, try again. I think the confusion is that when |titlestyle= is a template parameter, no quotes, but when it is inline css, you need quotes. omitting the quotes only works if there are no spaces. so, if there were a way to have no whitespace before the !important it would have probably worked. of course, we could have the template add the quotes, but that could create double quotes in some cases, which would probably break things. so, making a long story longer, a WP:BOTREQ to add quotes to all the transclusions without quotes is probably the way to go. Frietjes (talk) 14:19, 22 October 2024 (UTC)

Was that the only issue remaining? Everytime I signed back on it seemed like 3 other templates were found to be broken. ~ Dissident93 ^(talk) 18:30, 22 October 2024 (UTC)

@Dissident93 and Jkudlick: The secondary colors are still not being found by the templates. At 2023–24 Le Moyne Dolphins men's basketball team#Player_statistics, the text color in the column headings no longer matches. The wikilinked words in the heading were colored to match the text in the rest of the heading at the time the table was created, which was the secondary color. See

!colspan="3" style="{{NCAA color cell|Le Moyne Dolphins}}" |[[Field goal (basketball)|<span style="color: #FCE300">Field-goal</span>]] shooting

The term "Field-goal" was colored #FCE300, Le Moyne's secondary color, to render as gold (instead of blue, which did not provide sufficient contrast), the same as "shooting" rendered using {{NCAA color cell}}, when the table was created. With the quotes in the style statement, "shooting" renders as white, ignoring the secondary color. The changes made to the module that have caused the secondary color to be ignored must be further back than the changes that have recently been reversed. Taxman1913 (talk) 17:21, 23 October 2024 (UTC)

The module feels like it should just be entirely recoded to be more like other sports color modules, which doesn't have any of these issues. ~ Dissident93 ^(talk) 21:40, 23 October 2024 (UTC)

Template-protected edit request on 24 October 2024

Please add the following RSEQ team:

["UQAC Inuk"] = {"6B8915", "FFFFFF", "13100D", name1="green", name3="black", cite="{{cite web|url=https://www.uqac.ca/inuk/wp-content/uploads/2023/08/CouleursOfficielles.pdf |title=Couleurs Officielles |publisher=[[Université du Québec à Chicoutimi]] |language=French |access-date=October 24, 2024}}"},

Cmm3 (talk) 14:42, 24 October 2024 (UTC)

 Done ~ Dissident93 ^(talk) 23:36, 24 October 2024 (UTC)