Wikipedia talk:WikiProject User scripts/Scripts/CloseAFD
Working?
[edit]Does this still work? I added it to my monobook.js, bypassed cache, cleared cache, CTRL+SHIFT+R for my Firefox 3.. but I don't get a "close tab" on any Afd pages I visit. - ℅ ✰ALLST☆R✰ echo 20:35, 25 April 2009 (UTC)
question
[edit]Hi, is this different from User:Mr.Z-man/closeAFD2.js? --Randykitty (talk) 16:41, 15 December 2014 (UTC)
- This is a different script from Mr.Z-man's User:Mr.Z-man/closeAFD.js and his User:Mr.Z-man/closeAFD2.js. I wasn't aware of either of those until just now. Mr. Z, when you have a moment, I'd like to see what you think about merging the scripts into one to make it universal for everyone. I was thinking of merging a bunch of the various XfD closing scripts into one and adding sections for closing RfCs as well. I'd love to collaborate with you on this project. I'd love if you could at very least add support in your scripts to use the new parameter introduced into {{Relist}}. Thanks! — {{U|Technical 13}} (e • t • c) 17:03, 15 December 2014 (UTC)
- I was going to update my closeAFD to use jQuery, but the code was so old and convoluted, I just decided to rewrite it instead, which is what closeAFD2 is. closeAFD2 is functional and is basically 99% done, there's just a few minor bugs I haven't had time to fix. This script seems to be a bit more rudimentary, with a lot less automation than even my original one had. Mr.Z-man 03:42, 21 December 2014 (UTC)
- It does appear that way. When I have some free time, I intend to break this script apart and modularize it and expand it to all XfD areas as well as adapt it for RfXs and XRV discussions. When I'm ready to do that, I'll make sure I take both of your scripts into account to add functionality and maybe we can just get all of these scripts merged into one script. I'll drop by your talk page when I'm ready to do that. I will take care of the wikEd compatibility issue the week right after the holidays though. :) — {{U|Technical 13}} (e • t • c) 03:55, 21 December 2014 (UTC)
- Note that closeAFD2 is already fairly modular, with "generic" functions for things like editing and deleting a page. Mr.Z-man 16:36, 21 December 2014 (UTC)
- I'm currently working on adding support for the new parameters in {{relist}}, but it looks like the template behavior differs from the documentation. The documentation specifies
{{subst:relist|Comment|Number}}
, but it seems to actually work like{{subst:relist|Comment|Signature|Number}}
. Mr.Z-man 16:58, 23 December 2014 (UTC)
- Z, you are correct. Since it was undocumented, I'm assuming it isn't used and I've started deprecating its usage. The template should now work as documented. I'll be gone for a few days for the holiday, but I'll tie up loose ends and finish deprecating it in any script I find when I get back. — {{U|Technical 13}} (e • t • c) 18:24, 23 December 2014 (UTC)
Just tried this...
[edit]...on Wikipedia:Articles for deletion/Uładzimir Katkoŭski. Not working for me (monobooks, FF34). The script has definitely loaded, I can see the close and relist tabs when I go to edit mode, but they have no function when clicked. Even on that much, it is not looking to me like an improvement to the MrZman script. That script does not require going to edit mode, the tabs are already present on the AfD page, so one less click and one less page to load. Also, MrZman has the oldafdfull template fully automated, whereas this script, according to the instructions, requires the user to go to a separate tab. SpinningSpark 17:23, 15 December 2014 (UTC)
Another test
[edit]Also tried this before looking at the comments. Appears to be broken in Monobook. On the individual AfD pages, the close/relist tabs don't show unless you go to "edit" (but, as mentioned, they don't work there either). Reverting back to User:Mr.Z-man/closeAFD2.js. Feature request: relist/close straight from the daily list rather than having to open separate AfD pages for processing. Another feature request: if dev is continuing on Z-AFD2, I left a few bug reports over the last few months on their talk page. Easiest one is changing the capital "Delete" and "Keep" to lowercase. Thanks, all, for your work on this. czar ⨹ 22:04, 15 December 2014 (UTC)
- @Czar: what's the difference between User:Mr.Z-man/closeAFD.js and User:Mr.Z-man/closeAFD2.js? Is it documented somewhere? SpinningSpark 22:09, 15 December 2014 (UTC)
It's mostly just less-horrible code, but it has a few minor improvements too - it can handle AFDs of multiple articles and it uses the {{Old AfD multi}} template.
— User_talk:Mr.Z-man/Archive_15#closeAFD_stopped_relisting- I started using it when the auto-relist would trip on reading one of the daily AfD listings, and it's been pretty great, though it has a few bugs (noted a few in that quoted thread and on Z-man's current talk page). Not sure if any were addressed, but it's definitely still worth using. T13, I would recommend working on that one as it's pretty robust czar ⨹ 22:18, 15 December 2014 (UTC)
- @Czar: I think I've fixed all the bugs reported to date, plus a few more I found during testing. There were a few cases a while ago where it accidentally blanked the AFD log pages during relists. I don't know why that happened, but I added a check to make sure any page contains more than whitespace before saving it. It doesn't seem to have happened again (or at least no one reported it), so it may have just been a random Wikipedia bug. It also supports the optional comment and number parameters in the relist template. Mr.Z-man 23:14, 23 December 2014 (UTC)
Broken in Monobook?
[edit] Investigating... — {{U|Technical 13}} (e • t • c) 23:36, 15 December 2014 (UTC)
- Okay, so:
- I switched to Monobook to test
- Made the call to this script the only thing on my monobook .js
- Cleared the sandbox
- Relist #1
- Relist #2
- Relist #3
- Relist #4
- Relist #5
- Closed
- All of those diffs were made with the script (and I didn't have to manually disable wikEd). Ah-ha! I have found the problem. If you are not using wikEd at all, then it returns a
TypeError: window.wikEd is undefined
error. I'll debug this tomorrow night. Thanks! — {{U|Technical 13}} (e • t • c) 23:54, 15 December 2014 (UTC)
This edit request to Wikipedia:WikiProject User scripts/Scripts/CloseAFD.js has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |