Wikipedia:Bots/Requests for approval/WugBot 3
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was Approved.
Operator: Wugapodes (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)
Time filed: 03:25, Monday, June 24, 2019 (UTC)
Function overview: Transcludes an article's WP:DYK nomination on the article talk page.
Automatic, Supervised, or Manual: Automatic
Programming language(s): Python
Source code available: Yes dev branch
Links to relevant discussions (where appropriate): Wikipedia talk:Did you know#Proposal: automated notification of DYK nomination on article talk pages
Edit period(s): Daily
Estimated number of pages affected: About 20 nominations are added a day, so probably that many pages would be affected per day, not counting the first run which would likely be around 500-600.
Namespace(s): Talk
Exclusion compliant (Yes/No): Yes
Function details: Did you know nominations are contained on their own subpages in the Template namespace and transcluded on the nomination page. Once per day, the bot will go through the nominations and transclude the nomination subpage into a section on the article's talk page. It will not transclude the nomination if the page already has the nomination transcluded or if the page has {{bots|deny=.*?WugBot.*?}}
or {{nobots}} anywhere in its text. It will be similar in result to what Legobot's Task 33 does with GA reviews. An example can be seen at User:WugBot/DYKNoteTest.
Beyond the bot proper, I plan to make changes to {{DYK top}} and {{DYK bottom}} (one idea currently visible in their sandboxes) that will keep the review visible when transcluded in the Talk namespace. Currently, when a DYK nomination is closed, the {{DYKsubpage}} template is substed which substs DYK top and bottom which wraps the whole nomination in <noinclude> tags so it doesn't show on WP:DYKN. This would prevent it from showing up on the article talk page as well, which is not ideal. I'm still finalizing how I plan to fix this, the current plan is only having the <noinclude> tags added if transcluded outside the Talk namespace. I'm not sure if this works and am trying to figure out how to test it. But worst case, they may be modified to no longer add <noinclude>. Since WugBot's Task 2 removes closed DYK noms within two hours, this change should have minimal impact on the appearance of the pages.
Discussion
[edit]- DYK templates have been transcluded on to talk pages in the past so this is not a new idea. It has bothered me that they stop appearing once the DYK is done so I like that Wugapodes is going to fix this behaviour. Andrew D. (talk) 11:04, 25 June 2019 (UTC)[reply]
- Wugapodes, would it be possible to add a note at the top regarding where these templates are coming from? For example, the GA note at Talk:Iguana (song) tells why it's there and how to edit, but the (rather long) section at your test page doesn't, and it's really not obvious how to contribute and/or edit the nomination itself. Primefac (talk) 21:10, 27 June 2019 (UTC)[reply]
- Done. I tried to figure out some way to get it into the template but it wasn't cooperating so I just added it as text that the bot adds along with the transclusion. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 22:37, 27 June 2019 (UTC)[reply]
- Okay, last question regarding scope. I assume by your proposal that you'll basically hit all of the "backlog" of transclusions (500-600) in one go, and then proceed daily to transclude the new nominations? Primefac (talk) 13:23, 29 June 2019 (UTC)[reply]
- Yes. That's not so much what I want and more what I expect will happen given how the bot is written. For a trial it may be better to limit the bot to a certain number of edits per day, maybe 10 or 20, so that if there is a problem it's not spread across 500 pages on the first run. That shouldn't be hard, I already throttle the bot to 1 page per run to make the test page. I think it would also be a more manageable trial in terms of manually checking for errors. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 18:49, 29 June 2019 (UTC)[reply]
- Approved for trial (30 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. No preference if it comes from the "old" pages or nominations in the future. Primefac (talk) 19:09, 29 June 2019 (UTC)[reply]
- Thanks, I've configured the bot to do 5 per day so the trial should last about a week. The first run will be in about a half hour. I'll post updates here. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 20:32, 29 June 2019 (UTC)[reply]
- 15 edits in and the trial seems to be going well. Anyone who would like to look over the edits can find them easily by filtering WugBot's contributions. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 23:26, 1 July 2019 (UTC)[reply]
- Hrmm, upon checking the bot edits it seems like they all leave duplicate headers. Is it possible to change either the template or the bot so that only one header displays? Jo-Jo Eumerus (talk, contributions) 09:05, 2 July 2019 (UTC)[reply]
- @Jo-Jo Eumerus: You mean that there's also a level-4 header with the page's name, or this early problem? If the latter, I've resolved that. If the former, that would require some tweaking of {{subst:NewDYKNom}} Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 16:37, 2 July 2019 (UTC)[reply]
- Not sure what the difference is, but it seems like it might be the template that's the problem. Jo-Jo Eumerus (talk, contributions) 16:47, 2 July 2019 (UTC)[reply]
- I've changed {{subst:NewDYKNom}} so that it only includes a level 4 header if not transcluded on a talk page. Because that template is substituted, it will take a while for the change to propagate. I'll come up with an example soon. In the mean time, if you see any issues at DYK from this template, let me know. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 20:49, 2 July 2019 (UTC)[reply]
- Not sure what the difference is, but it seems like it might be the template that's the problem. Jo-Jo Eumerus (talk, contributions) 16:47, 2 July 2019 (UTC)[reply]
- @Jo-Jo Eumerus: You mean that there's also a level-4 header with the page's name, or this early problem? If the latter, I've resolved that. If the former, that would require some tweaking of {{subst:NewDYKNom}} Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 16:37, 2 July 2019 (UTC)[reply]
- Hrmm, upon checking the bot edits it seems like they all leave duplicate headers. Is it possible to change either the template or the bot so that only one header displays? Jo-Jo Eumerus (talk, contributions) 09:05, 2 July 2019 (UTC)[reply]
- Approved for trial (30 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. No preference if it comes from the "old" pages or nominations in the future. Primefac (talk) 19:09, 29 June 2019 (UTC)[reply]
- Yes. That's not so much what I want and more what I expect will happen given how the bot is written. For a trial it may be better to limit the bot to a certain number of edits per day, maybe 10 or 20, so that if there is a problem it's not spread across 500 pages on the first run. That shouldn't be hard, I already throttle the bot to 1 page per run to make the test page. I think it would also be a more manageable trial in terms of manually checking for errors. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 18:49, 29 June 2019 (UTC)[reply]
- Okay, last question regarding scope. I assume by your proposal that you'll basically hit all of the "backlog" of transclusions (500-600) in one go, and then proceed daily to transclude the new nominations? Primefac (talk) 13:23, 29 June 2019 (UTC)[reply]
- Done. I tried to figure out some way to get it into the template but it wasn't cooperating so I just added it as text that the bot adds along with the transclusion. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 22:37, 27 June 2019 (UTC)[reply]
- You can see an example at Talk:Joe Biden (The Onion) (with no level-4 header) and {{Did you know nominations/Joe Biden (The Onion)}} which does have the level-4 header. A thanks to Brandt Luke Zorn for an amusing test case. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 22:36, 2 July 2019 (UTC)[reply]
- There's an error at Talk:IM 67118 where the bot didn't recognize that a nomination had already been transcluded. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 22:59, 3 July 2019 (UTC)[reply]
- Trial complete. For convenience, here is a list of the 30 trial edits. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 06:36, 5 July 2019 (UTC)[reply]
- {{BAG assistance needed}} Been about a week, thoughts on how to proceed? Wug·a·po·des 07:02, 12 July 2019 (UTC)[reply]
- Trial complete. For convenience, here is a list of the 30 trial edits. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 06:36, 5 July 2019 (UTC)[reply]
- There's an error at Talk:IM 67118 where the bot didn't recognize that a nomination had already been transcluded. Wugapodes [thɑk] [ˈkan.ˌʧɹɪbz] 22:59, 3 July 2019 (UTC)[reply]
Approved. As per usual, if amendments to - or clarifications regarding - this approval are needed, please start a discussion on the talk page and ping. --TheSandDoctor Talk 23:31, 20 July 2019 (UTC)[reply]
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.