Wikipedia:Bots/Requests for approval/SporkBot 8

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Speedily Approved.

SporkBot 8

Operator: Plastikspork (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 14:37, Tuesday, July 14, 2020 (UTC)

Function overview: Update template parameters in Template:Infobox mountain per a discussion on the talk page as requested by User:Rehman

Automatic, Supervised, or Manual: Semi-supervised (completely supervised at the start, then automatic with a log file that will be reviewed after the run).

Programming language(s): Perl using the MediaWiki::Bot library

Source code available: Standard Perl regular expressions

Links to relevant discussions (where appropriate): [1]

Edit period(s): One time with possible second run if there are subsequent reverts or oversights.

Estimated number of pages affected: 25,000 (per whatlinkshere for Infobox mountain)

Namespace(s): Mainspace

Exclusion compliant (Yes/No): Yes

Function details: See the tables in [2] copied here for convenience

Rename parameters (updated)
From	To
Duplicates
`photo_width`	`photo_size`
`coords`	`coordinates`
`topo`	`topo_map`
`relief`	`map_relief`
`parent`	`range`
`image_map`	`map_image`
`coords_ref`	`coordinates_ref`
`coordinates_note`	`coordinates_ref`
`elevation_note`	`elevation_ref`
`city_type`	`settlement_type`
Renames
`type`	`mountain_type`
`state_type`	`subdivision1_type`
`region_type`	`subdivision2_type`
`district_type`	`subdivision3_type`
`part_type`	`subdivision4_type`
`range_coordinates_note`	`range_coordinates_ref`
`grid_ref_Ireland_note`	`grid_ref_Ireland_ref`
`grid_ref_UK_note`	`grid_ref_UK_ref`
`length_note`	`length_ref`
`width_note`	`width_ref`
`area_note`	`area_ref`
`volume_note`	`volume_ref`

Consolidate parameters (updated)
Source (in order)	Destination
`borders_on`	Move contents to `borders_on`, in the same order.
`border`
`border1`
`border2`
`border3`
`border4`
`border5`
`border6`
`border7`
`border8`
`volcanic_region`	Move contents to `volcanic_region`, in the same order.
`volcanic_arc/belt`
`volcanic_arc`
`volcanic_belt`
`volcanic_field`
`geology`	Move contents to `geology`, in the same order.
`geology1`
`geology2`
`geology3`
`geology4`
`geology5`
`rock`
`age`	Move contents to `age`, in the same order.
`period`
`period1`
`period2`
`period3`
`period4`
`country`	Move contents to `country`, in the same order. For articles that used `country1` and not `country_type`, please append the additional parameter `\|country_type=Countries`.
`country1`
`country2`
`country3`
`country4`
`country5`
`country6`
`country7`
`country8`
`settlement`	Move contents to `settlement`, in the same order. For articles that used `settlement1` or `city1`, but not `settlement_type` or `city_type`, please append the additional parameter `\|settlement_type=Settlements`. For articles that use `city_type`, please copy it to `settlement_type`
`settlement1`
`settlement2`
`city`
`city1`
`city2`
`city3`
`city4`
`city5`
`city6`
`city7`
`city8`
`city9`
`city10`
`city11`
`city12`
`city13`
`city14`
`city15`
`city16`
`subdivision1`	Move contents to `subdivision1`, in the same order. For articles that have `state_type`, copy it to `subdivision1_type` For articles that do not use `state1`, please append the additional parameter `\|subdivision1_type=State`. For articles that use `state1`, please append the additional parameter `\|subdivision1_type=States`.
`state`
`state1`
`state2`
`state3`
`state4`
`state5`
`state6`
`state7`
`state8`
`subdivision2`	Move contents to `subdivision2`, in the same order. For articles that use `region_type`, please copy it to `subdivision2_type` For articles that use `region1` and `state1` please append the additional parameter `\|subdivision2_type=Regions`. For articles that use `region1` and not `state1>` please append the additional parameter `\|subdivision2_type=States/Provinces`
`region`
`region1`
`region2`
`region3`
`region4`
`region5`
`region6`
`region7`
`region8`
`region9`
`region10`
`region11`
`region12`
`region13`
`region14`
`region15`
`region16`
`region17`
`region18`
`region19`
`region20`
`region21`
`region22`
`region23`
`subdivision3`	Move contents to `subdivision3`, in the same order. For articles that use `district_type`, please copy it to `subdivision3_type` For articles that use `district1`, please append the additional parameter `\|subdivision3_type=Districts`.
`district`
`district1`
`district2`
`district3`
`district4`
`district5`
`district6`
`district7`
`district8`
`district9`
`subdivision4`	Move contents to `subdivision4`, in the same order. For articles that use `part_type`, please copy it to `subdivision4_type` For articles that use `part1`, please append the additional parameter `\|subdivision4_type=Subdivisions`.
`part`
`part1`
`part2`
`part3`
`part4`
`part5`
`part6`
`part7`
`part8`
`part9`
`part10`
`part11`
`part12`
`part13`
`part14`
`part15`
`part16`
`language`	Convert the language name to it's ISO 639-3 code and move to `native_name_lang`.

Discussion

@Plastikspork and Rehman: Overall, this bot reflects the consensus of editors at Template talk:Infobox mountain. However, there are a few details that need to be fixed before we unleash the bot on 25,000+ articles. I've spent the last several weeks cleaning up hundreds of Mountain infoboxes, so I've gotten familiar with current usage patterns. I think we need to tweak what the bot will do. Here are my recommendations:

|border= is used for much more than ranges. There are many mountain ranges in the Western United States where |border= is used for valleys, deserts, or even roads. Thus, I would suggest moving the content to |borders=, not |border_ranges=.
For |region=, the current infobox uses the label "Regions" if |state= is defined, and uses "States/Provinces" if |state= is not defined. Some mountain ranges in Europe rely on this. So, I would change the logic --- if region1 is defined and state is define, then set |subdivision2_type=Regions. If region1 is defined and state is undefined, set |subdivision2_type=States/Provinces
|language= should not be moved to |native_name_lang=, because they are not duplicates. |language= is for the full name of the language (e.g., "Spanish") while |native_name_lang= is for the ISO-639-3 code of the language (e.g., "es").

Thanks for building the bot, Plastikspork! — hike395 (talk) 07:09, 17 July 2020 (UTC)[reply]

@Hike395 and Rehman: Fine with me. Let me know if there are any other changes. Thanks! Plastikspork _―Œ^(talk) 13:41, 17 July 2020 (UTC)[reply]

Please hold this for now. I didn't expect this last minute change. I'll bring this up at the template talkpage (so as to not clutter BRFA) and update here in due course. Thank you. Reh man 14:20, 17 July 2020 (UTC)[reply]

After some discussions and minor tweaks, we're good to go! Reh man 04:06, 22 July 2020 (UTC)[reply]

Sorry, found another minor issue --- we need to copy over parameters like |state_type=, |district_type=, etc. to the new label parameters. I've fixed the specification, above. @Plastikspork: this bot has a lot of edge cases that are rather tricky. Would you like me to code review your Perl? — hike395 (talk) 07:06, 22 July 2020 (UTC)[reply]

Thanks for making the table a clearer. Based on my previous experience with the bot, such cases (i.e. conflicts in parameter values) would be listed separately for manual action (and not actioned by the bot); making the code less complex. Hence I did not specify. But anyway, the clearer it is, the better. Cheers, Reh man 08:40, 22 July 2020 (UTC)[reply]

Speedily Approved. Trusted operator with solid plan. Primefac (talk) 22:19, 2 August 2020 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.