Wikipedia:Bots/Requests for approval/MDanielsBot 4

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

MDanielsBot 4

Operator: Mdaniels5757 (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 15:08, Sunday, June 21, 2020 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): PHP

Source code available: https://tools.wmflabs.org/botwatch/source.php?file=parse.php

Function overview: Remove stale (older than 6 hours) AIV reports (in SQLBot's absence)

Links to relevant discussions (where appropriate): Wikipedia:Bots/Requests for approval/SQLBot 6, Wikipedia:Administrators'_noticeboard#AIV_Needs_Attention

Edit period(s): Continuous

Estimated number of pages affected: 1

Exclusion compliant (Yes/No): No

Already has a bot flag (Yes/No): No

Function details: Clone (identical code) of SQLBot 6's task. The bot would remove AIV reports (and associated comments) after the parent report is ~~6 hours old~~ between 4 and 8 hours old, varying as a function of active admins as described at User:SQL/AIVStale. Would run every 30 minutes.

Discussion

Just noting that SQLBot’s programming was dynamic. As the number of active admins increases, the time it takes to clear approaches 4 hours. As the number of active admins decreases, it approaches 8 hours. Reading code isn’t exactly my thing, but just wanted to see if you accounted for that/were aware since you said the code is identical. TonyBallioni (talk) 15:14, 21 June 2020 (UTC)[reply]
- @TonyBallioni: Thanks for catching that (I was going off what was in the original BRFA). SQL's full explanation is at User:SQL/AIVStale. Also, it doesn't write to SQL's userspace (that'd be rude). Cheers, --Mdaniels5757 (talk) 15:39, 21 June 2020 (UTC)[reply]
Kudos to SQL for posting code to this bot so someone else could run it during their absence (that should be required for all these maintenance bots), and also to Mdaniels5757 for being willing to take it on for now. My one suggestion (if you haven't already done so) is to email SQL to let them know this is happening and to coordinate giving it back when the time comes. 2602:24A:DE47:BB20:50DE:F402:42A6:A17D (talk) 01:03, 23 June 2020 (UTC)[reply]
Approved for trial (50 edits or 7 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Whichever comes first. Primefac (talk) 17:13, 24 June 2020 (UTC)[reply]
- Trial complete. (7 days, 36 edits). No issues that I've noticed. --Mdaniels5757 (talk) 17:08, 1 July 2020 (UTC)[reply]
  - Approved. Primefac (talk) 21:12, 6 July 2020 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.