Wikipedia:Bots/Requests for approval/HiW-Bot 2
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was Approved.
Operator: Hedwig in Washington (talk · contribs)
Time filed: 02:32, Friday January 27, 2012 (UTC)
Automatic or Manual: manual, semi automatic
Programming language(s): Pywikipediabot
Source code available: Standard pywikipedia
Function overview: I like to have the bot add the template {{Commonscat|NameOfCategory}} if such a category exists on Commons.
Links to relevant discussions (where appropriate):
Edit period(s): Maybe daily, probably more like 3 times a week
Estimated number of pages affected: I have no clue, total pages with Commonscat template = 269,461 and with Template Commons = 311,586. So I guess it might be somewhere around 1k - 10 k.
Exclusion compliant (Y/N): Y
Already has a bot flag (Y/N): Y
Function details: Nothing fancy, put Commonscat, next patient please...
Discussion
[edit]After trawling through the templates {{Commonscat}} and {{Commons}} I have come to the view that you are asking to convert calls to {{Commons|category:NameOfCategory[|OtherParams]}} to {{Commons category|NameOfCategory[|OtherParams]}}, but you have not specified that you will be operating on redirects per http://toolserver.org/~dispenser/cgi-bin/rdcheck.py?page=Template:Commons
Have I understood your intentions? Josh Parris 06:45, 27 January 2012 (UTC)[reply]
- Funny :-) Adding Commonscat/Commons category has not been done for a long time and now there is 2 requests. I made the same request 2 days ago on Wikipedia:Bots/Requests for approval/MGA73bot 4. --MGA73 (talk) 10:33, 27 January 2012 (UTC)[reply]
- @MGA73:Yep, it is funny. I added some Commons tags on dewiki by hand - a heck of a time! :) So I thought why not use PWB? IF we both get approved, we should split the load by dividing ENWIKI in half so we don't cancel each other out. :)
- @Josh Parris: I should have been more precise: No converting planned (even though I think it will happen automatically) just finding categories on Commons and adding them into the article.
- @HiW: Lets do the split like this: I take the easy ones and you take the rest ;-) Anyway my plan is to work in Category namespace. Would you work on articles? --MGA73 (talk) 09:38, 29 January 2012 (UTC)[reply]
- Y That's fine. --Hedwig in Washington (TALK) 21:42, 30 January 2012 (UTC)[reply]
Here's the copy of MGA73's disc:
MGA73 Disc
[edit]How do you plan on dealing with incorrect interwiki links? Josh Parris 13:10, 27 January 2012 (UTC)[reply]
- (HiW) AFAIK wrong iw have no effect on this script since it looks for the same name for the category on Commons
What will happen when multiple wikis point at different commons categories? Josh Parris 13:10, 27 January 2012 (UTC)[reply]
- (HiW) That shouldn't happen in the first place. But IMHO this will have no effect.
I see that commonscat.py was last updated in 2010; have any of the supported templates changed since then? Josh Parris 13:10, 27 January 2012 (UTC)[reply]
- (HiW) Nothing changed that makes the script run wild.
Will you be using the -always parameter? Josh Parris 13:10, 27 January 2012 (UTC)[reply]
- (HiW) Not until I know for sure that there will be no problem.
There's a TODO list in commonscat.py - will you be doing any of the TODOs? Josh Parris 13:10, 27 January 2012 (UTC)[reply]
- (HiW) No, I am not a Python coder at all. I'd make the script brew coffee or something else. :-)
General query
[edit]Remind me how you know it's a relevant category with regard to the content of the article? - Jarry1250 [Deliberation needed] 15:18, 30 January 2012 (UTC)[reply]
- That's simple: Name of article = name of Commons cat = fire at will. If they differ, one has to review both article and Commons cat. That's how I do it on dewiki.
- FYI: Changed from automatic mode to manual since there are some pitfalls ahead. --Hedwig in Washington (TALK) 21:42, 30 January 2012 (UTC)[reply]
- Yes, I was going to say, I think name alone is unwise, since there are a handful of historical differences in naming. How much scrutiny is involved in "semi-automatic"? - Jarry1250 [Deliberation needed] 23:45, 30 January 2012 (UTC)[reply]
- Exactly. Hope for the best isn't working anymore :-) Well, there's not much one can do: if there is a match, press y, if not switch to commons and have a look. That's it. Even on dewiki there are a lot more matches (the few times I tried it out) than I thought so I believe it will work out just fine. --Hedwig in Washington (TALK) 05:46, 31 January 2012 (UTC)[reply]
- Yes, I was going to say, I think name alone is unwise, since there are a handful of historical differences in naming. How much scrutiny is involved in "semi-automatic"? - Jarry1250 [Deliberation needed] 23:45, 30 January 2012 (UTC)[reply]
{{BAG assistance needed}}
Whats the status? --MGA73 (talk) 14:17, 4 February 2012 (UTC)[reply]
Trial
[edit]Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. MBisanz talk 15:19, 6 February 2012 (UTC)[reply]
- In my bot request there is a few things that will help this bot to work better. Just as an info. --MGA73 (talk) 10:23, 7 February 2012 (UTC)[reply]
- I mean that if we orphan and delete redirects and change
{{Commons|Category:Whatever}}
to{{Commons category|Whatever}}
it will be easier to maintain the bot script that we use (commonscat.py) for the main task. --MGA73 (talk) 07:17, 8 February 2012 (UTC)[reply]- working on some more edits. stay tuned ;)) --Hedwig in Washington (TALK) 20:47, 17 February 2012 (UTC)[reply]
- I mean that if we orphan and delete redirects and change
Trial complete.
I reviewed six edits.
- http://en.wikipedia.org/w/index.php?title=Havarti&diff=prev&oldid=476789703 is an interesting choice of category. Can you explain it?
- http://en.wikipedia.org/w/index.php?title=%27Asir_Province&diff=prev&oldid=475443849 has the commons box below the topic boxes. Quoting: "In articles, this template should normally be placed at the top of the ==External links== section, if one exists, or at the top of the last section on the page, if no external links section exists." In fact, I see all edits misplace the box.
Josh Parris 10:30, 19 February 2012 (UTC)[reply]
- I checked a handful more and there is a definite issue about placement. (Even to the extent that the previous edits should be fixed using AWB, I should be forced to say.) - Jarry1250 [Deliberation needed] 12:56, 19 February 2012 (UTC)[reply]
- Havarti edit: Bot asked to add Category, I wanted to deny but pressed y instead. Human error.
- Asir and following edits: Yes, it's misplaced, I'll try to figure out how to change that. For work in Namespace Category the edits are fine (AFAIK)
- I'll check back in a few days, will contact pwb developer.
- --Hedwig in Washington (TALK) 21:39, 19 February 2012 (UTC)[reply]
- Bug tracker -> here
- Per the comment, did updating your bot fix the problem? Josh Parris 02:50, 20 February 2012 (UTC)[reply]
- Bug tracker -> here
I'd like to continue with ns:category only. Is that ok? I'll stop as soon as there's a placing problem. Meaning 1 edit in category and then check. If ok, maybe a few more. Max 10 ok? --Hedwig in Washington (TALK) 21:52, 19 February 2012 (UTC)[reply]
- First, clean up the mess your bot's created - then we'll talk. Josh Parris 02:50, 20 February 2012 (UTC)[reply]
- Changed all template positions. That was on my list, I just wanted to wait for you guys to have a look first so I don't do cosmetic changes only, and I thought it might be easier to review. Well, at least it is done.
- No, the bot is updated daily. That is not the problem. The PWB-Team will have a look at the problem. And I really don't want to do another edit without approval. :)
- I would suggest to put commonscat.py for articles via bot on ice for now. The work of MGA73bot seems to be fine, since it only works on categories.
- --Hedwig in Washington (TALK) 19:35, 20 February 2012 (UTC)[reply]
Trial 2
[edit]Approved for trial (20 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. cat: namespace only. Be clear: until the developers fix commonscat.py it must not be used in article space. Josh Parris 09:47, 21 February 2012 (UTC)[reply]
- I agree, since the tool doesn't seem to work for namespace 0, it shouldn't be used. I restarted in namespace 14. Thx. --Hedwig in Washington (TALK) 18:26, 21 February 2012 (UTC)[reply]
Trial complete.
Approved. Category namespace only come back and file a new BRfA referring to this one when the devs fix commonscat.py Josh Parris 11:35, 24 February 2012 (UTC)[reply]
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.