Wikipedia:Bots/Requests for approval/ASammourBot

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Withdrawn by operator.

ASammourBot

Operator: ASammour (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 09:26, Thursday, October 8, 2015 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): Java

Source code available: No

Function overview: The bot will work in this list of categories, which is stubs categories. The bot will search in the pages of each category, if it found in the content of the article "category:...stub"; it will replace it with the template of the stub. More details here

Links to relevant discussions (where appropriate): The idea is taken from here.

Edit period(s): Continuous.

Estimated number of pages affected: I have no specific number, but it will be the number of pages that contains stub category.

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): No

Function details:

The bot will work in the list above.
The bot will get the category members of the category.
Then it will loop througt the pages of the category.
if found the stub category in the content, and the article content doesn't has stub template; the bot will remove the stub category, and replace it with the stub template.
if found the stub category in the content, and found stub template; it will remove the category and keep the template.

Discussion

I unblocked the bot for you. This task seems fine and I'm glad to see you pick it up. Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. The one issue that strikes me is WP:STUBSPACING; make sure per convention that you put the stub template at the absolute end of the page, with two blank lines separating it from any categories. — Earwig ^talk 19:49, 8 October 2015 (UTC)[reply]

The bot's edit summary isn't normal English. Instead of having it say Test of replace stub category to stub template, could you have it say Test of replacing stub category with stub template instead? Nyttend (talk) 00:49, 10 October 2015 (UTC)[reply]

Nyttend; Surely. I've updated the edit summary. Thanks.--ASammour (talk) 03:48, 10 October 2015 (UTC)[reply]

You're welcome, and thank you. Nyttend (talk) 11:01, 10 October 2015 (UTC)[reply]

In this case, since there are multiple stub templates, you shouldn't add the extra newlines between the two. — Earwig ^talk 06:28, 10 October 2015 (UTC)[reply]

I fix it. Thanks for that.--ASammour (talk) 14:45, 10 October 2015 (UTC)[reply]

I'm little disappointed about this task's results. The bot has worked in about 5000 categories from the total (13,000), and just 7 articles has been edited. The Earwig; Should I continue?.--ASammour (talk) 18:56, 10 October 2015 (UTC)[reply]

There must be something wrong, as according to the original discussion there should be over 2,700 articles with this problem. All of your edits so far seem to be removing categories using underscores (e.g. [[Category:Foo_stubs]]) rather than spaces (e.g. [[Category:Foo stubs]]). Perhaps you aren't checking for categories correctly? — Earwig ^talk 20:10, 10 October 2015 (UTC)[reply]

You're right. The problem was because the underscore. I've made 70 edits now, there was some mistakes, and i fix it all. please kindly see the latest contributions.--ASammour (talk) 00:07, 11 October 2015 (UTC)[reply]

(←) Marking as Trial complete. Some things:

Kirchweih ends up with triple newlines. Not a big deal as the generated HTML should be the same, I think, but it should be fixed.
Latino Cultural Center, Fugazi (EP), Gejia people: stub template added twice. I would make the template check case-insensitive. Also, you should check if the page includes templates that are redirects to the desired stub template. It didn't happen in the trial, but if you aren't doing so already, watch out for things of the form {{Template:Foo-stub}}. Not sure how common that is.

— Earwig ^talk 01:22, 11 October 2015 (UTC)[reply]

That was because the Last item in the aricle was has new line before it. So when the bot add the stub template after two lines; it became 3 lines.
I've fixed the duplicate of the stubs. also I fixed the case sensitive issues. and I've make the bot fix the article which has {{template:..-stub}}). Any other things will be welcomed. Would you like to make few edits to check the fixed things?.--ASammour (talk) 10:30, 11 October 2015 (UTC)[reply]

Sure. Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. — Earwig ^talk 19:56, 11 October 2015 (UTC)[reply]

I've made almost 30 edits. There are no problems in the edits.--ASammour (talk) 22:33, 11 October 2015 (UTC)[reply]

I've made another 20 edits. and also there is no problem.--ASammour (talk) 18:30, 13 October 2015 (UTC)[reply]

Trial complete. I'll take a look soon. — Earwig ^talk 18:33, 13 October 2015 (UTC)[reply]

@ASammour: Sorry, been busy with work.

It doesn't look like you fixed the redirect issue? On J. T. Adams and Joseph Arthur (playwright), the bot adds the stub template twice.
On Affendy Akup, Adi Said, and Dagon (novel), the bot adds the correct stub template... but an existing stub template already adds that category, so it should probably remove the category only.
I can't understand what the bot is doing on Abu Bakar Mahari.

Thanks. — Earwig ^talk 23:03, 18 October 2015 (UTC)[reply]

{{OperatorAssistanceNeeded}} — Earwig ^talk 02:36, 5 November 2015 (UTC)[reply]

I'm very sorry for being late. I completley forgot the request.

Now I've fixed it.
I don't understand what is the problem in these edits. Could you please give more clarification?.
That was because I run threads in my bot (for performance purposes); Sometimes it could be a conflict between data; like what happen in the edit above. Now, I've fixed this problem. Would you like to run the bot for another 50 edits?.--ASammour (talk) 08:50, 10 November 2015 (UTC)[reply]

@ASammour: Hi, no rush. The problem with those edits is the bot adds an unnecessary extra stub tag. If we look at this one, for example, the article started out with {{Brunei-footy-bio-stub}}, which according to its documentation adds three stub categories, including Category:Bruneian sport stubs. So, the bot should be removing [[Category:Bruneian sport stubs]] only rather than also adding a stub template, since it is redundant. I hope that clarifies it. — Earwig ^talk 04:39, 11 November 2015 (UTC)[reply]

Sorry, But i couldn't configure a way to avoid edits like you mention. How the bot could find out the stub is duplicate from the stub category?. Is there a way to do that?. I'm sorry; because this request took long time.--ASammour (talk) 12:44, 19 November 2015 (UTC)[reply]

@ASammour: My suggestion is to have the bot look at each stub template on the page, read its source (see example), and build a list of the all categories already included by stub templates. If a category on the page is within that list, it can be safely removed without needing a new stub template to be added. The rest of the bot should work mostly the same. — Earwig ^talk 16:30, 19 November 2015 (UTC)[reply]

Withdrawn by operator. Special:Permalink/694200103#Suspend bot request for approval. — Earwig ^talk 19:25, 7 December 2015 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.