Template talk:Sort under

This is the talk page for discussing improvements to the Sort under template.

Put new text under old text. Click here to start a new topic.
New to Wikipedia? Welcome! Learn to edit; get help.

Suggest making class=sort-under the default. That being the one with the centered icons

Jroberson108. This is easier to remember and do. It follows this pattern of adding a dash, and nothing else, to form these TemplateStyles classes:

{{mw-datatable}}{{static row numbers}}{{sticky header}} 
{| class="wikitable sortable mw-datatable static-row-numbers sticky-header"

I just copy and paste these 2 rows to many tables. The pattern is obvious to others too. --Timeshifter (talk) 07:00, 28 January 2024 (UTC)[reply]

@Timeshifter: Adding a sort-under class would be 16 extra selectors in the styles, so I would rather not. Originally, I was going to have one class (right aligned) and no other alignment options, but decided to offer a second option. Jroberson108 (talk) 07:09, 28 January 2024 (UTC)[reply]

Jroberson108. At Template:Sort under/styles.css wouldn't just removing all instances of "-center" accomplish what I am asking for? Most people want the icon in the center.

So there would be only 2 classes:

sort-under

sort-under-right

By the way, so far I have looked at the template doc examples in iphone SE 2020 in Safari, Firefox, Edge, Chrome, and Opera. All the examples look good, and they sort fine. And the unsortable class is working too (not sorting). --Timeshifter (talk) 07:32, 28 January 2024 (UTC)[reply]

Good to know it works in your iPhone browsers. I thoroughly tested it in Windows 10 Chrome/Edge/Firefox (all skins), Android Chrome/Firefox (Minerva skin), and Android Wikipedia app. Jroberson108 (talk) 07:36, 28 January 2024 (UTC)[reply]

In the iphone all the browsers were in mobile view. I looked at the bottom of the template page in each browser just now, and they all had the "desktop" toggle link.

There is something to be said for simplicity. Template:Sticky header may be new, but it is already popular: Over 400 transclusions so far:

https://templatecount.toolforge.org/index.php?lang=en&namespace=10&name=Sticky_header#bottom

Currently, {{sort under}} is not transcluded in any article pages. So making "class=sort-under" the default class will not cause any major problems. There is no need for "class=sort-under-center".

{{Sorting row}} only has 200+ transclusions currently:

https://templatecount.toolforge.org/index.php?lang=en&namespace=10&name=Sorting_row#bottom

It is not easy to use, because it is easy to place it in the wrong place. And it doesn't allow attributes to its header cells.

{{sort under}} will be used much more if its pattern follows the typical TemplateStyles simplicity. --Timeshifter (talk) 08:49, 28 January 2024 (UTC)[reply]

You don't need to continue pushing your same opinion. I've heard you, considered it even before you brought it up, and disagree. This template offers two alignment options, which these classes clearly describe. I literally just went live with it by sharing a link at phab:T35249. Give others time to review it and give their opinions, if they are still interested. You are welcome to invite other editors to review the template. If there is a strong consensus from several editors that only one alignment is needed, which could be "right" not "center", then I will remove one and shorten the other. Like I mentioned earlier, I originally was going to have one short class for moving it under while maintaining the current right alignment. The only reason I added a center option is because I see in the other template and the related phab task that there is some preference. I have not seen others clearly give the same preference, so I gave clear options with the option of adding a clear "left" if there is enough demand. Jroberson108 (talk) 15:43, 28 January 2024 (UTC)[reply]

Thanks for creating this template. I provided more reasons for my point of view. That is not "pushing" my point of view. I don't appreciate that characterization.

I agree with getting more opinions, and doing as you say (I paraphrase): Use class=sort-under for the more popular choice.

I left requests for comments (directing them here) at Help talk:Table, Help talk:Sortable tables, Wikipedia:Village pump (technical), and Phab:T35249. --Timeshifter (talk) 22:15, 28 January 2024 (UTC)[reply]

You're welcome, and hopefully this template helps. If you were just giving more reasons to support your opinion, then I apologize and mean no offense. I just want to hear from others too. Thanks for reaching out for more comments. Jroberson108 (talk) 22:19, 28 January 2024 (UTC)[reply]

Here is an example of a table excerpt (from here) with columns with differing text alignment. It uses {{sorting row}}. Specifically:

Intentional homicide victims per 100,000 inhabitants. From UNODC.
Location	Rate	Count	Year	Region	Subregion
Afghanistan *	4.0	1,613	2021	Asia	Southern Asia
Anguilla	28.3	4	2014	Americas	Latin America and the Caribbean

I think it would look weird for those left-aligned text columns to have right-aligned sorting icons.

Tables using {{table alignment}} often have a mixture of column alignments. And nearly all tables have a left-aligned first column. --Timeshifter (talk) 00:51, 31 January 2024 (UTC)[reply]

I realize I haven't given my own preferences, so I'll just state them here, not that it matters since no other editors have joined for almost a week. Mine is for right alignment because that is the normal location where sortable and other spreadsheet applications put it. Even adding a separate sorting row without {{sorting row}} aligns it right unless otherwise styled. Left aligned seems usable only on sites that have right-to-left text like Arabic. Center aligned is too prominent for something that isn't content, and distracts my reading experience when going from the header to its data. On wider columns, right aligned arrows are far less distracting than on narrower columns. I'm fine with this template offering both right and center alignment for the different preferences, but if I had to choose one, then it would be right alignment. Jroberson108 (talk) 03:40, 3 February 2024 (UTC)[reply]

OK. I am surprised that anybody likes it right aligned when the sorting icon is below the column header text. No one ever complained about {{sorting row}} being center aligned, that I remember.

I asked for comments at the Village Pump instead of here. See:

Wikipedia:Village pump (technical)#Please comment here concerning Template:Sort under

I put up 3 tables there for people to choose from. --Timeshifter (talk) 08:40, 3 February 2024 (UTC)[reply]

I don't recommend splitting the discussion in two locations, it's just going to confuse things further. Also, it's not a "choose one" discussion, but a "multiple or one". Jroberson108 (talk) 08:48, 3 February 2024 (UTC)[reply]

It's not working here. We tried, and as you said: "no other editors have joined for almost a week."

It's a "choose one" discussion concerning a default class: class=sort-under for the more popular choice.

I doubt anyone will choose left-aligned. But if so, it is no big deal to provide that option too. We have 2 classes now: (center and right-aligned).

It is common to go to the Village Pump for more opinions, expert advice, etc. when discussion is inadequate elsewhere.

--Timeshifter (talk) 09:14, 3 February 2024 (UTC)[reply]

I'm haven't been discussing "choose one" for a "default" or, as you put it, "popular choice" class. I've already said I'm against it and repeatedly said that the current classes clearly describe the alignments. I would never propose adding ambiguity when there are multiple options. What I am discussing is this: "If there is a strong consensus from several editors that only one alignment is needed, which could be "right" not "center", then I will remove one and shorten the other." Jroberson108 (talk) 09:56, 3 February 2024 (UTC)[reply]

Here, and on 4 different talk pages trying to get people here, I specifically said that we would use class=sort-under for the more popular choice. I thought you agreed, and said so (see previous posts). Your statement above sounded like that to me. If it was an incorrect interpretation, you waited a long time to correct me.

Now you are back to your original position of ignoring my point about simplicity working to make templates get used more.

You don't own this template even though you did the initial work on it. Let's see what others say.

There is no reason there can't be 4 options. Left, right, center, and default.

In fact since you are so dead set against using the default class=sort-under option, then don't use it. But we will let others use it. Those who want to use the long version can do so. Everybody is happy. No one is imposing their class on another. Those, like me and many others, who want to save time, will use class=sort-under, knowing it is the more popular choice. --Timeshifter (talk) 10:59, 3 February 2024 (UTC)[reply]

I've been very clear in my responses even clealy saying "disagree" and brought up an alternative. I didn't correct you because it sounded like you were just rallying support for your "default" preference and they were going to respond on this talk page and see what was being discussed anyways. The responses moved, so I responded. I don't waste my time trying to correct everything everyone might say incorrectly. You are using some choice words I don't appreciate like "ignoring" that doesn't assume good faith. I disagreed, not ignored. As far as adding four options, my first response also applies. You've provided no solid metrics to back your claim of "templates get used more" or "saves time" and pointed to no discussions showing consensus for "many others" or "popular". I agree that there needs to be a consensus for the requested changes. Jroberson108 (talk) 13:07, 3 February 2024 (UTC)[reply]

I wrote previously: "I agree with getting more opinions, and doing as you say (I paraphrase): Use class=sort-under for the more popular choice. I left requests for comments (directing them here) at Help talk:Table, Help talk:Sortable tables, Wikipedia:Village pump (technical), and Phab:T35249."

You didn't say anything about disagreeing with that. So it is too late to disagree now that people will be responding assuming that they are responding concerning a default class=sort-under.

And anyway I provided a solution that lets people use whatever alignment they want: 4 options. Left, right, center, and default.

Unless you find consensus against that I will put it into the CSS myself. Maybe not for left, if no one wants it.

And what is this disrespectful BS: "You've provided no solid metrics to back your claim of 'templates get used more' or 'saves time'."

I told you it saved me time. That should be good enough since you know that I edit a lot of tables. --Timeshifter (talk) 13:57, 3 February 2024 (UTC)[reply]

Get consensus for the requested changes. Jroberson108 (talk) 14:54, 3 February 2024 (UTC)[reply]

For those who are interested. Someone at the technical Village Pump suggested going to this MOS discussion page since it is a style discussion, and not a technical problem. See:

Wikipedia talk:Manual of Style/Tables#Template:Sort under

--Timeshifter (talk) 14:07, 4 February 2024 (UTC)[reply]

Sort under makes table float to the center

A table using sort under on WTA 1000 Series singles records and statistics#Title leaders floats centered. Removing it fixes the issues. Can you please fix this? Qwerty284651 (talk) 17:03, 1 July 2024 (UTC)[reply]

@Qwerty284651: This template isn't causing it. You can remove this template and most of the columns and see the table is still centered. Removing the table's "margin:auto" style fixes it. Jroberson108 (talk) 17:47, 1 July 2024 (UTC)[reply]

Changing it to margin:0 resolved it. Qwerty284651 (talk) 18:00, 1 July 2024 (UTC)[reply]

I removed margin:0. It doesn't seem necessary. See table after I formatted it further:

https://en.wikipedia.org/w/index.php?title=WTA_1000_Series_singles_records_and_statistics&oldid=1232157291#Title_leaders

--Timeshifter (talk) 07:49, 2 July 2024 (UTC)[reply]

I made the table with sticky row headers for easier navigability when horizontally scrolling on mobile. That's why margin:0 was used to remove the whitespace Template:COVID-19 pandemic data/styles.css causes.

I also proposed some new designs of the table on the project's talk page. How do I remove the whitespace caused by {{columns-list}}? Qwerty284651 (talk) 13:09, 2 July 2024 (UTC)[reply]

OK. Feel free to revert some of my changes. I may do it sooner. Sticky row headers are nice. ~~I am not seeing them though in Firefox~~ at Wikipedia talk:WikiProject Tennis#1000 title leaders charts. I am seeing them in Chrome there. Maybe Jroberson108 can help with that there.

I don't know where you are using {{columns-list}}.

If it is a possibility for the table header glossary above the table, then I suggest that this is better, and more compact:

Help:Tables and locations#Glossary flat list for table header abbreviations

And it wraps better as the screen width narrows. --Timeshifter (talk) 17:19, 2 July 2024 (UTC)[reply]

Try zooming in to 200/250% to see the sticky headers or go on mobile. I proposed the columns list in versions 1-3 on WT:TEN. Qwerty284651 (talk) 17:26, 2 July 2024 (UTC)[reply]

Firefox problem with showing sticky row headers has been fixed on WT:TEN#1000 title leaders charts.

The flat-list glossary fixes the white-space problem. I mean the unneeded space between {{columns-list}} and the table. --Timeshifter (talk) 19:53, 2 July 2024 (UTC)[reply]

Sticky rows CSS code adds whitespace, which I resolved it with margin:0. Qwerty284651 (talk) 19:56, 2 July 2024 (UTC)[reply]

I was experimenting with columns list, wanted them to be listed column by column rather than by row with the glossary. Qwerty284651 (talk) 19:59, 2 July 2024 (UTC)[reply]

Let's discuss whitespace further at WT:TEN to avoid duplication. --Timeshifter (talk) 20:42, 2 July 2024 (UTC)[reply]

Already doing that. Qwerty284651 (talk) 20:47, 2 July 2024 (UTC)[reply]

Regulating the arrow height

Is there a way to regulate the height of the sorting arrow row (for e.g., height:2em, the height of regular data cells), similar to what {{Sorting row}} was able to do before it got deleted? Using a combination of links with arrows increases the chance of accidentally clicking on the links instead of the arrows. See List of Grand Slam and related tennis records#Career Golden Slam, for example. Qwerty284651 (talk) 14:58, 6 September 2024 (UTC)[reply]

I like the current height. Making the header taller is bad for scrolling sticky tables. Less room for data rows in landscape view in the scroll window in my iphone SE 2020 which does not have the larger screen found in many other mobile phones. Especially when there are multiple header rows plus the sorting row from this template. Pinging Jroberson108.

Blank row for arrows

No.	Player	Discipline	AO	FO	WIM	USO	OLY

1	Pam Shriver	Women's doubles	1982	1984	1981	1983	1988

With sort under

No.	Player	Discipline	AO	FO	WIM	USO	OLY
1	Pam Shriver	Women's doubles	1982	1984	1981	1983	1988

Without sort under

No.	Player	Discipline	AO	FO	WIM	USO	OLY
1	Pam Shriver	Women's doubles	1982	1984	1981	1983	1988

--Timeshifter (talk) 17:04, 6 September 2024 (UTC)[reply]

With padding-bottom=2em

No.	Player	Discipline	AO	FO	WIM	USO	OLY
1	Pam Shriver	Women's doubles	1982	1984	1981	1983	1988

-- Qwerty284651 (talk) 23:57, 6 September 2024 (UTC)[reply]

@Qwerty284651 and Timeshifter: Yeah, I see your point. It's done by adding padding-bottom to the th cell that has the sort button or unsortable class. It would have to be adjusted through the styles, maybe a new class, since each skin is slightly different and it keeps the {{static row numbers}} label aligned. Even with the sort buttons to the right I easily fat-finger it on mobile. Jroberson108 (talk) 23:37, 6 September 2024 (UTC)[reply]

The th cell? Also, the above excerpt of the table doesn't use {{static row numbers}}. Qwerty284651 (talk) 23:50, 6 September 2024 (UTC)[reply]

Got it. Thanks. Qwerty284651 (talk) 23:57, 6 September 2024 (UTC)[reply]

The header cell is the th cell. Jroberson108 (talk) 00:09, 7 September 2024 (UTC)[reply]

In the 4th table "With padding-bottom=2em": can you make the arrows more centralized within the respective col headers, equidistant from the bottom border and the text above it? Qwerty284651 (talk) 00:32, 10 September 2024 (UTC)[reply]

Basically, to remove "bottom" in Template:Sort_under/styles.css, lines 50–60

from

/**
   * Reposition arrows.
   */
  html.client-js .sort-under-center.sortable th.headerSort {
    background-position: center bottom 0.2em;
  }
  html.client-js .sort-under.sortable th.headerSort,
  html.client-js .sort-under-right.sortable th.headerSort {
    background-position: right bottom 0.2em;
  }

to

/**
   * Reposition arrows.
   */
  html.client-js .sort-under-center.sortable th.headerSort {
    background-position: center 0.2em;
  }
  html.client-js .sort-under.sortable th.headerSort,
  html.client-js .sort-under-right.sortable th.headerSort {
    background-position: right 0.2em;
  }

Qwerty284651 (talk) 01:02, 10 September 2024 (UTC)[reply]

@Qwerty284651 and Timeshifter: No, that CSS property is complicated and doesn't work that way. The spacing seems needed only on touch screen devices since I don't have any issues using a more accurate mouse pointer. I added some sandbox styles with what seems like enough space to prevent a fat-finger error, or I can increase it a little more. You can see it on your touch screen device (tablet, phone) at Template:Sort under/testcases#Compare wikitable. I tested my Android phone. Jroberson108 (talk) 04:18, 10 September 2024 (UTC)[reply]

Changes are live. Jroberson108 (talk) 18:13, 13 September 2024 (UTC)[reply]