Jump to content

Template talk:Gridiron primary style

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Move discussion in progress

[edit]

There is a move discussion in progress on Template talk:NFLPrimaryColor which affects this page. Please participate on that page and not in this talk page section. Thank you. —RMCD bot 21:45, 4 June 2018 (UTC)[reply]

performance

[edit]

There seems to be an issue with this template in some articles. E.g. 1930 Brooklyn Dodgers (NFL) season is running out of time executing scripts. No indication why, and it’s not like it’s an overlong or overtemplated article. But looking at the page source the template timing data has 

Transclusion expansion time report (%,ms,calls,template)
100.00% 10111.533      1 -total
 99.29% 10039.928      1 Template:Infobox_NFL_season
 99.24% 10034.953      1 Template:Infobox
 99.15% 10025.521      1 Template:NFLPrimaryStyle
  0.30%   30.662      1 Template:Use_mdy_dates
  0.16%   16.308      1 Template:1930_NFL_standings
  0.12%   12.289      1 Template:DMCA
  0.12%   11.939      7 Template:Tooltip
  0.11%   10.698      1 Template:Dated_maintenance_category
  0.10%    9.665      1 Template:1930_NFL_season_by_team

This is one of a handful of articles in Category:Pages with script errors. All Brooklyn Dodgers and Chicago Rush seasons, which suggests something to do with their data perhaps.--JohnBlackburnewordsdeeds 03:33, 22 June 2018 (UTC)[reply]

I think I see the problem. In Module:Gridiron color/data the data for both the "Brooklyn Dodgers 1930thru1943" and "Chicago Rush 2001thru2012" is recursive. It’s probably in an infinite loop trying to interpret it and running out of time. No idea how to fix it though, i.e. what to replace it with.Pinging Cmm3, Ahecht and Charlesaaronthompson who have worked on the data.--JohnBlackburnewordsdeeds 04:03, 22 June 2018 (UTC)[reply]
@JohnBlackburn: See Module_talk:Gridiron_color#Infinite_loop. I'm working on it. --Ahecht (TALK
PAGE) 04:07, 22 June 2018 (UTC)[reply]
Lets's try that ping again: @JohnBlackburne:. --Ahecht (TALK
PAGE) 04:23, 22 June 2018 (UTC)[reply]
The module has been updated so it should avoid such infinite loops, even if the data is bad. It's still possible to create infinite loops if you really try (e.g. ["Team A"] = "Team B" and ["Team B"] = "Team A"), but it at least prevents the situations seen with the Brooklyn Dodgers and Chicago Rush. --Ahecht (TALK
PAGE) 16:09, 22 June 2018 (UTC)[reply]
Retrieved from "https://en.wikipedia.org/w/index.php?title=Template_talk:Gridiron_primary_style&oldid=1210989889"