Template talk:Foo–Bar relations category

Template-protected edit request on 23 January 2023

A number of country locator maps have a n-dash separating the country names. Currently, the map finder template does not find them as the code expects a space as separator. I suggest to add other tests to also find locator maps using n-dash. Examples: no map is currently displayed on Category:Latvia–Sweden relations, Category:Latvia–San Marino relations, Category:Bolivia–France relations, Category:Gabon–Russia relations, Category:Australia–Chad relations etc. whereas the maps exist (File:Latvia–Sweden Locator.svg, File:Latvia–San Marino Locator.svg, File:Bolivia–France Locator.svg, File:Gabon–Russia Locator.svg, File:Australia–Chad Locator.svg).

I suggest to replace this code:

from X to Y

-->|<!-- ## No map found, so return nothing by this: ## Some maps also use a n-dash (–) -->{{#ifexist: Media:{{{country1}}}–{{{country2}}} Locator.png<!-- -->|{{{country1}}}–{{{country2}}} Locator.png<!-- -->|<!-- no .png, so try .svg -->{{#ifexist: Media:{{{country1}}}–{{{country2}}} Locator.svg<!-- -->|{{{country1}}}–{{{country2}}} Locator.svg<!-- -->|<!-- no map for {{{country1}}}–{{{country2}}}, so try reverse order -->{{#ifexist: Media:{{{country2}}}–{{{country1}}} Locator.png<!-- -->|{{{country2}}}–{{{country1}}} Locator.png<!-- -->|<!-- no .png, so try .svg -->{{#ifexist: Media:{{{country2}}}–{{{country1}}} Locator.svg<!-- -->|{{{country2}}}–{{{country1}}} Locator.svg<!-- -->|<!-- ## No map found, so try again with uncapitalised "locator" -->{{#ifexist: Media:{{{country1}}}–{{{country2}}} locator.png<!-- -->|{{{country1}}}–{{{country2}}} locator.png<!-- -->|<!-- no .png, so try .svg -->{{#ifexist: Media:{{{country1}}}–{{{country2}}} locator.svg<!-- -->|{{{country1}}}–{{{country2}}} locator.svg<!-- -->|<!-- no map for {{{country1}}}–{{{country2}}}, so try reverse order -->{{#ifexist: Media:{{{country2}}}–{{{country1}}} locator.png<!-- -->|{{{country2}}}–{{{country1}}} locator.png<!-- -->|<!-- no .png, so try .svg -->{{#ifexist: Media:{{{country2}}}–{{{country1}}} locator.svg<!-- -->|{{{country2}}}–{{{country1}}} locator.svg<!-- -->|<!-- ## No map found, so return nothing -->}}<!-- -->}}<!-- -->}}<!-- -->}}<!-- -->}}<!-- -->}}<!-- -->}}<!-- -->}}<!--

– Place Clichy (talk) 13:32, 23 January 2023 (UTC)

Please make your required changes to Template:Foo–Bar relations category/mapname/sandbox and do some testing to make sure it works. When ready, do reactivate the request. Thanks — Martin (MSGJ · talk) 09:27, 24 January 2023 (UTC)

PS This template desperately needs converting to Lua! — Martin (MSGJ · talk) 09:29, 24 January 2023 (UTC)

@MSGJ: Changes applied, with a slight change from the proposition above and a reduction of indentation to make the code more readable. The new code indeed succeeds in finding the maps mentioned above:

* {{Foo–Bar relations category/mapname/sandbox|country1=Latvia|country2=Sweden}} returns : Latvia–Sweden Locator.svg

* {{Foo–Bar relations category/mapname/sandbox|country1=Gabon|country2=Russia}} returns : Gabon–Russia Locator.svg

On a wider scale, a test at Category:Latvia–Sweden relations with code {{Foo–Bar relations category/sandbox}} displays the map (this can only be tested in preview though). So all tests are positive.

I also note (for memory) that the population of tracking categories with the current version of the template is the following:

• A location map is generated: Category:Template Foo–Bar relations category with a locator map (population: 4,544)
• No location map is generated: Category:Template Foo–Bar relations category with no locator map (population: 4,516)
• "map=" has a non-nil value: Category:Template Foo–Bar relations category with specified map (population: 7)
• "map=" has a non-nil value, but the page specified does not exist: Category:Template Foo–Bar relations category with non-existent specified map (population: 0)

I expect these values to change significantly with the proposed edit. Place Clichy (talk) 15:45, 24 January 2023 (UTC)

 Done — Martin (MSGJ · talk) 10:51, 26 January 2023 (UTC)

@MSGJ: unfortunately, another user felt necessary to sync the sandbox to the live template before your change, so no changes were made to the target template in the end. May I kindly ask you to try again? Place Clichy (talk) 23:11, 26 January 2023 (UTC)

To editors Place Clichy and Martin: please forgive my boo boo. Thought the edit had already been made. Rectified by making the sandbox edit to the live template, and so  done. P.I. Ellsworth , ed. ^put'r there 23:41, 26 January 2023 (UTC)

 Thanks! The template now works as expected, with previously unidentified maps showing up automatically, e.g. on Category:Latvia–Sweden relations. Place Clichy (talk) 23:47, 26 January 2023 (UTC)