Template talk:DNB12

update

To be consistent with {{cite DNB}} / {{DNB}} and {{cite DNB12}}, I propose to update this template to use Module:template wrapper. See testcases.

—Trappist the monk (talk) 12:19, 9 June 2019 (UTC)

In the testcases, one test 'fails'. I do not consider this to be a 'failure'. The live template accepts |prescript= without a value an uses that empty value as the prescript:

{{DNB12|prescript=|wstitle=O'Sullivan, Cornelius}}

 This article incorporates text from a publication now in the public domain: Lee, Sidney, ed. (1912). "O'Sullivan, Cornelius". Dictionary of National Biography (2nd supplement). London: Smith, Elder & Co.

This action is, to me, nonsensical. {{DNB12}} converts {{cite DNB12}} into an attribution template by the inclusion of the prescript. If editors don't want the prescript, they should use {{cite DNB12}}:

{{cite DNB12|wstitle=O'Sullivan, Cornelius}}

Lee, Sidney, ed. (1912). "O'Sullivan, Cornelius" . Dictionary of National Biography (2nd supplement). London: Smith, Elder & Co.

The sandbox version of the template renders the same way when |prescript= is empty and when it is omitted:

{{DNB12/sandbox|prescript=|wstitle=O'Sullivan, Cornelius}}

 This article incorporates text from a publication now in the public domain: Lee, Sidney, ed. (1912). "O'Sullivan, Cornelius". Dictionary of National Biography (2nd supplement). London: Smith, Elder & Co. {{cite encyclopedia}}: Invalid |ref=harv (help)

{{DNB12/sandbox|wstitle=O'Sullivan, Cornelius}}

 This article incorporates text from a publication now in the public domain: Lee, Sidney, ed. (1912). "O'Sullivan, Cornelius". Dictionary of National Biography (2nd supplement). London: Smith, Elder & Co. {{cite encyclopedia}}: Invalid |ref=harv (help)

—Trappist the monk (talk) 22:53, 9 June 2019 (UTC)

There having beenn no comment, done.

—Trappist the monk (talk) 13:12, 21 June 2019 (UTC)