Talk:Hardware-based encryption

This is the talk page for discussing improvements to the Hardware-based encryption article.
This is not a forum for general discussion of the article's subject.

Put new text under old text. Click here to start a new topic.
New to Wikipedia? Welcome! Learn to edit; get help.

Article policies

Find sources: Google (books · news · scholar · free images · WP refs) · FENS · JSTOR · TWL

Hardware-based encryption was a Engineering and technology good articles nominee, but did not meet the good article criteria at the time. There may be suggestions below for improving the article. Once these issues have been addressed, the article can be renominated. Editors may also seek a reassessment of the decision if they believe there was a mistake.

Article milestones
Date	Process	Result
June 5, 2018	Good article nominee	Not listed

A fact from this article appeared on Wikipedia's Main Page in the "Did you know?" column on February 11, 2018.

The text of the entry was: Did you know ... that hardware-based encryption is probably in your computer?

Computing

	This article is within the scope of WikiProject Computing, a collaborative effort to improve the coverage of computers, computing, and information technology on Wikipedia. If you would like to participate, please visit the project page, where you can join the discussion and see a list of open tasks.ComputingWikipedia:WikiProject ComputingTemplate:WikiProject ComputingComputing articles
???	This article has not yet received a rating on the project's importance scale.

Cryptography: Computer science

	This article is within the scope of WikiProject Cryptography, a collaborative effort to improve the coverage of Cryptography on Wikipedia. If you would like to participate, please visit the project page, where you can join the discussion and see a list of open tasks.CryptographyWikipedia:WikiProject CryptographyTemplate:WikiProject CryptographyCryptography articles
???	This article has not yet received a rating on the importance scale.
	This article is supported by WikiProject Computer science.

This article is written in British English, which has its own spelling conventions (colour, travelled, centre, defence, artefact, analyse) and some terms that are used in it may be different or absent from other varieties of English. According to the relevant style guide, this should not be changed without broad consensus.

GA Review

RESULT

Failed criteria 3a (broad in coverage), 2c (no WP:OR), and 4 (editorializing)

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

This review is transcluded from Talk:Hardware-based encryption/GA1. The edit link for this section can be used to add comments to the review.

Reviewer: Spinningspark (talk · contribs) 10:08, 20 May 2018 (UTC)[reply]

This is not going to be a full review because I think this article has a major problem with criterion 3a: "broad in its coverage". That puts it in immediate fail territory so I am going to limit my initial comments to that issue.

The lead says that "hardware-based encryption is the use of computer hardware to..." which establishes that computers are necessarily involved in encryption. This is not so, the article itself discusses the enigma machine, but dismisses it as not computer based. Logically, we could go back further to simple devices such as the diode coding matrix. I could also mention 1950s-60s style telephone scramblers, entirely hardware based.

I'm particularly concerned with the claim that ABYSS was the first hardware based encryption in 1987. Even if we accept that only computer-based encryption is being discussed, neither of the sources seem to state the fact (perhaps you could give an exact quote). Also, the use of "arguably" not only breaches WP:WTW but is an indication that editorialising is going on here.

This might be in a better place if the article had a different name, such as "Computer hardware based encryption". But as it stands, it needs a major rewrite and restructuring to be acceptable. SpinningSpark 10:08, 20 May 2018 (UTC)[reply]

I agree, DES was created in the 70's and was mainly implemented in hardware which is a decade before ABYSS. There were a number of military hardware systems in use before DES which was civilian, and with its short key length accessible by the NSA/GCHQ. Enigma style machines continued into the 70s. Today there are a lot of hardware systems for encyption/decryption, look at bitcoin mining for the rapid process in problem solving using hardware in this area. RonaldDuncan (talk) 15:29, 5 June 2018 (UTC)[reply]

Ok, I'm failing the article at this point. There has been zero response from the nominator, not even to acknowledge the review is happening. SpinningSpark 16:25, 5 June 2018 (UTC)[reply]

The discussion above is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.