Talk:Committer
 | This article is rated Stub-class on Wikipedia's content assessment scale. It is of interest to the following WikiProjects: | ||||||||||
| |||||||||||
 | The contents of the Commit bit page were merged into Committer on 12 April 2014. For the contribution history and old versions of the redirected page, please see its history; for the discussion at that location, see its talk page. |
Without prior review
[edit]Hi User:Voomoo, I was wondering why you deleted the line "Unlike other developers on a project, a committer is usually allowed greater freedom to make changes to the code without prior review." from the Committer article. You say it isn't so on any of the projects you work on, but it is so on all of the projects I work on. I think the key phrase is "without prior review" which means that committers can make commits without having to have it signed off by someone else before the commit lands on trunk/master/develop/whatever (post-commit review is common in many projects, but that wouldn't invalidate the sentence in question). If that isn't the case, why give people commit access if not to commit things themselves? Greg G (talk) 16:36, 27 April 2011 (UTC)
- On every project I have worked on, and I've worked on several projects, comitters were expected to get pre-commit review on the patches they wrote. The difference between them and others is that they were allowed to commit their own patches once they got review. I would expect any decent project to not allow just one person to review non-trivial changes (where non-trivial depends on the project).
- The reason to give people commit access to avoid the need to have 1 person review every single patch. Typically, although not always, good projects have a "get it acked by one other person" policy. A non comitter would then need it acked by two people (the committer, and the 'one other person') —Preceding unsigned comment added by Voomoo (talk • contribs) 16:45, 14 May 2011 (UTC)
Merge from 'Commit bit'
[edit]Support the merge proposal.Cander0000 (talk) 05:22, 23 August 2011 (UTC)
Sources committer roles and responsibilities
[edit]"As a committer, you have access rights to a specific Apache project's repository so you can create and edit source code files, not just read them.. Instead of having to create and submit a patch which other committers would have to review and approve, you can now create a local patch and commit it yourself; you can also review and commit patches that other project contributors and committers create. Your patches can still be reviewed by your fellow committers."