User talk:DannyS712/EFFPRH.js

Plain globals

@DannyS712: I know you copied this from User:Enterprisey/AFCFFU.js , but FWIW that had a number of plain globals present (wgPageName), etc.) that should probably be dealt with, so this does too. ~ Amory (u • t • c) 17:56, 12 August 2020 (UTC)[reply]

@DannyS712: Re-pinging here. Looks like you've got a few others besides this, at User:DannyS712/Undo.js and User:DannyS712 test/shortdesc.js, though I'm not sure how in-use those are. ~ Amory (u • t • c) 12:08, 29 January 2021 (UTC)[reply]

@Amorymeltzer thanks for the ping. I fixed this script, and don't see any isues at undo.js and shortdesc.js (both of those have the variables declared first) DannyS712 (talk) 18:26, 29 January 2021 (UTC)[reply]

Yeah, sorry about that — I was trying to be broad with regex, missed manual checking on those. ~ Amory (u • t • c) 18:30, 29 January 2021 (UTC)[reply]

Javascript error

@DannyS712:. Hello my friend. Just wanted to let you know that I think your most recent edit to this script is throwing a JavaScript syntax error in the console. $('#effp_status').append($ $error );. Hope that helps, thanks and have a great day. –Novem Linguae (talk) 05:51, 2 March 2022 (UTC)[reply]

@Novem Linguae -should be fixed DannyS712 (talk) 13:26, 2 March 2022 (UTC)[reply]

Replying to wrong section

@DannyS712: When I use this script, it replies to the section above instead of the section that I selected. Could you please fix this? Thanks. 0xDeadbeef→∞ (talk to me) 04:54, 20 November 2022 (UTC)[reply]

Always, or is there a specific diff? –Novem Linguae (talk) 15:33, 20 November 2022 (UTC)[reply]

Always. 0xDeadbeef→∞ (talk to me) 04:12, 3 December 2022 (UTC)[reply]

I tried to use the script again and it still responded to the wrong section. @Novem Linguae and DannyS712: 0xDeadbeef→∞ (talk to me) 13:26, 4 December 2022 (UTC)[reply]

@0xDeadbeef sorry I've been gone for a while and didn't see this issue - try using User:DannyS712/EFFPRH/sandbox.js instead, its a rewrite using vue that I think doesn't have this issue DannyS712 (talk) 15:58, 4 December 2022 (UTC)[reply]

That worked, thanks. 0xDeadbeef→∞ (talk to me) 23:56, 4 December 2022 (UTC)[reply]

@DannyS712: any updates on this? While not every time like for Deadbeef, twice now when I've tried to use the helper ([1], [2]) it has responded not to the report I've selected, but the one above it. Sideswipe9th (talk) 03:10, 23 June 2023 (UTC)[reply]

@Sideswipe9th I've updated the sandbox script to work again with codex DannyS712 (talk) 02:39, 2 October 2023 (UTC)[reply]

Suggestion

Could you add an optional input box for "Done (no change to filter)" for the diff of the edit? Thanks! Rusty4321 ^{talk contribs} 21:28, 16 October 2023 (UTC)[reply]

Question

@DannyS712 is there a way to prevent the tool from prepending a bullet point to the reply? Instead of:

Not done – The filter is working properly.

This would be posted:

Not done – The filter is working properly.

Thanks. Philipnelson99 (talk) 15:52, 16 January 2024 (UTC)[reply]

@Philipnelson99 there is not such an option at the moment --DannyS712 (talk) 22:57, 16 January 2024 (UTC)[reply]

Twinkle

@DannyS712: I was trying to find a way to disable Twinkle, but it kept popping up, and I traced it to this script.

Why does the script need Twinkle? I don't see a need for it in the function call that it is loaded in.

User:DannyS712/EFFPRH.js, line 474:

mw.loader.using(['ext.gadget.Twinkle', 'mediawiki.util', 'mediawiki.api', 'mediawiki.Title'], function() {
	$(document).ready( function () { 
		setTimeout(function (){
			if ( mw.config.get( "wgPageName" ) === "Wikipedia:Edit_filter/False_positives/Reports" || mw.config.get( "wgPageName" ) === "User:DannyS712/EFFPRH/sandbox" ) {
				effp_links();
			}
		}, 1000);

	} );
});

Rusty 🐈 01:27, 16 August 2024 (UTC)[reply]