Template talk:CIHplayer

Round info

Thinking of adding a way for the template to handle if the NHL pick is only given as a round rather than overall. Not all sources give the full info but it would be nice to be able to use what they did. -Raden (talk) 20:49, 25 April 2015 (UTC)[reply]

At the moment I changed it so it will need to be explicitly round or pick, but if we add an "NHLround" value we can check for that vs "NHL pick" and automatically fill in "_ round" or "_ overall" accordingly. That seems to be the best option as it has little impact on the current tables, so I'll look into doing that. -Raden (talk) 21:14, 25 April 2015 (UTC)[reply]

Fixed it so it is now a new variable. Current implementations will be unaffected, check the docs for more info. -Raden (talk) 21:41, 25 April 2015 (UTC)[reply]

Checking dates

I edited the template (diff) to add |fix=on as a parameter for {{age in days}}. The reason for that is that the age template has been changed to use Module:Age which checks that dates are valid. {{CIHplayer}} is sometimes used with zero as the birth year or month or day (zero meaning that the value is unknown). The module normally rejects zero as invalid and puts the article where it is used in a hidden error tracking category. My edit was a quick-and-dirty workaround to make zero behave the same as it did in the old age template. That's a bit complex to explain here but it is probably not what is wanted, although it's better than an error. Unfortunately, |fix=on means that invalid birth dates in {{CIHplayer}} will be "fixed"—for example, April 31 would be fixed to become May 1. That's not a big deal since the age is only used as a sort key but a cleaner solution would be best. Johnuniq (talk) 10:41, 25 April 2018 (UTC)[reply]