Module talk:National squad

Template-protected edit request on 2 September 2020

Implement Special:permalink/976342160 to wikilink sport specific article for compitation in title. It will be useful for this merger. Tested at Template:National squad no numbers/testcases (second testcase). → Timbaaa_talk 12:51, 2 September 2020 (UTC)

Timbaaa, do we know how many transclusions are not using |comp link=? this will potentially cause a change in the linking for all of them. For example, it would break the links in 1996 UEFA Futsal Championship squads, and Template:Bahrain squad 2007 AFC Asian Cup. Frietjes (talk) 15:30, 2 September 2020 (UTC)

Frietjes, Come to think of it, transclusion without |team link= is breaking team link in the title. In the same example 1996 UEFA Futsal Championship squads, all the links are to football squads as opposed to futsal squads.

In that case, for the merger to go on, |sport= has to be made a required parameter. And football be removed as default. → Timbaaa_talk 03:11, 3 September 2020 (UTC)

For what it's worth, I have a list of all templates using this module, divided by sport, at User:S.A. Julio/Squad navboxes. S.A. Julio (talk) 03:29, 3 September 2020 (UTC)

finding and fixing all of them seems like a large task (now tracking with Category:Pages using national squad without comp link). if this feature were "opt in" with |auto comp link=y or something, we wouldn't need to worry about fixing current uses. Frietjes (talk) 15:42, 2 September 2020 (UTC)

I think we have two issues

1. the sport parameter which was added in June 2020. if you check, before that in both the LUA and non-LUA versions, sport=football was "hard coded". the reason why the futsal links are wrong is because User:Primefac redirected the futsal template here but some of the transclusions were never updated. I simple check of the remaining transclusions to add |sport=futsal would fix that problem. however, I agree that making |sport= mandatory is a good idea in the longer term (unless |team link= is used in templates like Template:2008 United States Ryder Cup team).
2. the proposed change would still break links even when |sport= is set properly in templates like Template:Bahrain squad 2007 AFC Asian Cup, which currently links to 2007 AFC Asian Cup but would link to the redundant Football at the 2007 AFC Asian Cup without either (a) explicitly adding |comp link= to all transclusions without it or (b) making this feature opt-in. Frietjes (talk) 14:55, 3 September 2020 (UTC)

   Frietjes, Explicitly adding |comp link= on all transclusions will be difficult, so making it an opt-in feature. Check Special:permalink/976616587, using new |auto sport comp link=(If you can improve the snippet, please do I'm still learning). Included Template:Bahrain squad 2007 AFC Asian Cup in test cases to verify. → Timbaaa_talk 00:43, 4 September 2020 (UTC)

 Administrator note Has this change been tested at all, and if so is it ready to deploy? — Martin (MSGJ · talk) 12:12, 11 September 2020 (UTC)

MSGJ, I'll close the request. Seems it is causing some problems. → Timbaaa _talk 06:10, 12 September 2020 (UTC)

 Not done for now: Needs more testing. → Timbaaa _talk 06:14, 12 September 2020 (UTC)

Gender issue

I was going to start a run of converting the various "national <sport> squad" templates, but after checking Template:Argentina FH Squad 1983 Pan American Games I noticed that if |gender=male and the national team has "men's" in the title (in this case, Argentina men's national field hockey team) the template ends up directing the user to the dab redirect Argentina national field hockey team. This issue shows up if |team_link= isn't specified and the "<country> national <sport> squad" is a dab (which appears to be the case for field hockey). What is the best way to deal with this? Personally, I think defaulting to either "men's" or "women's" based on gender is the way to go (from a quick check it looks like most of the footy articles would redirect correctly, as would basketball). Primefac (talk) 00:45, 20 November 2020 (UTC)

And yes, I do realize that at this particular moment Template:Argentina FH Squad 1983 Pan American Games isn't using {{national squad}}, but that's because I want to make {{National field hockey squad}} into a redirect for future use; I only changed the Argentina template's call in Preview mode. Primefac (talk) 00:47, 20 November 2020 (UTC)

Courtesy ping to Frietjes. Primefac (talk) 03:01, 25 November 2020 (UTC)

Primefac, we could

1. make the default "men's" and track any redlinks, or
2. make the default "men's" when gender is "male" or "men's" and the default "" when gender is "" and track any redlinks,
3. use different defaults depending on sport so FH uses "men's" when gender is "male" or "men's"

I will tweak the tracking to see if there are any current uses outside of the typical |sport= or |sport=football and aren't using |team link=. if I recall the last time I checked all the atypical sports are using |team_link=. I, personally, don't like the fact that |sport= is the same as |sport=football. it should be a required parameter when |team link= isn't being used (tracked in Category:Pages using national squad without sport or team link). Frietjes (talk) 15:42, 25 November 2020 (UTC)

I'm thinking #2 might be good; I feel like there will be fewer redlinks that way (some sports may not be split by gender). As far as |sport= goes, I added that mostly because at the time the module could only do footy, so mandating the param would require updating all of the templates (wasn't sure how many there were, so that was easier). I'm fine with making sport required and changing any templates that need it. Primefac (talk) 16:08, 25 November 2020 (UTC)

I implemented #2 but without any redlink tracking, but with unusual gender tracking and unusual sport tracking. hopefully nothing breaks. Frietjes (talk) 15:42, 26 November 2020 (UTC)

Larger numbers and 00

@Frietjes: I had to change Template:Italy national basketball team roster to support 00 and larger numbers. Can we support this directly? Thanks! Plastikspork _―Œ^(talk) 18:12, 30 November 2020 (UTC)

I've put in support for the latter (just bumping from 40 to 99), though I'm not sure how we'd tweak 00 other than as you've done in the template call itself. Primefac (talk) 18:14, 30 November 2020 (UTC)

Okay, I have added support for 00 (see test cases). Thanks! Plastikspork _―Œ^(talk) 18:33, 30 November 2020 (UTC)

looks good, thank you! Frietjes (talk) 23:39, 30 November 2020 (UTC)

other default values

If default values everywhere is redefine, then perhaps they should be different. Maybe the code

local titlestyle = 'background-color:' .. (args.bg or 'transparent') .. ';'
		.. 'color:' .. (args.fg or 'inherit') .. ';' 
		.. 'border: 1px solid ' .. (args.bordercolor or '#aaa') .. ';'

should be replaced with

local titlestyle = (args.bg and 'background-color:' .. args.bg .. ';' or '') 
		.. (args.fg and 'color:' .. args.fg .. ';' or '')  
		.. (args.bordercolor and 'border: 1px solid ' .. args.bordercolor .. ';' or '')

. Thus, this parameters will not be set at all if they are not explicitly exactly specified in template. Why is such strange value (transparent) chosen at all? --Туча (talk) 01:18, 19 April 2021 (UTC)

 Not done for now: please establish a consensus for this alteration before using the {{edit template-protected}} template. I'm not strictly opposed to this change, but I do think that it is something that needs at least some discussion before being enacted. Also, has it been sandboxed to ensure proper functioning? If it gets sandboxed and there is no voiced opposition in a week or so, feel free to re-open this per WP:SILENCE. Primefac (talk) 12:24, 19 April 2021 (UTC)

Preview warning and hatnotes moving to templatestyles

Page watchers may be interested in MediaWiki talk:Common.css § Preview warning and hatnotes moving to TemplateStyles Izno (talk) 00:22, 29 April 2021 (UTC)